lp:~3v1n0/bamf/factory-ref-rework

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:bamf at revision 547

Andrea Azzarone (community): Approve on 2013-06-13

PS Jenkins bot (community): Approve (continuous-integration) on 2013-06-13

Ted Gould (community): Approve on 2013-06-13

Diff: 451 lines (+164/-87)

4 files modified

debian/changelog (+9/-10)
lib/libbamf/bamf-factory.c (+135/-75)
lib/libbamf/bamf-view.c (+19/-1)
src/bamf-matcher.c (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1176524: Implicit functions declarations in bamf-matcher.c	Medium	Fix Released
Bug #1181717: compiz crashed with SIGSEGV in g_object_unref() from unity::bamf::Application::~Application()	Critical	Fix Released

Link a bug report

Related blueprints

569. By Marco Trevisan (Treviño) on 2013-06-13

BamfFactory: comment wording fix

568. By Marco Trevisan (Treviño) on 2013-06-13

BamfFactory: only care about closed views when rematching

It's unsafe to try to rematch an allocated view that is not closed, since it could lead to a
path change. We were not able do this before since we had no way to get if a view
was closed if its remote owner disappeared. With gdbus this is easily possible, instead.

567. By Marco Trevisan (Treviño) on 2013-06-13

BamfView: set a view closed if the name-owner has changed to an invalid value...

This happens when bamf-daemon is killed/closed and thanks with gdbus we can now
track this case to handle it properly.

566. By Marco Trevisan (Treviño) on 2013-06-13

BamfView: make the closed signal to run_last.

565. By Marco Trevisan (Treviño) on 2013-06-13

BamfFactory: only remove all values from hashtable on dispose, destroy it on finalize

564. By Marco Trevisan (Treviño) on 2013-06-13

BamfFactory: weak_unref all the allocated views before of being disposed

563. By Marco Trevisan (Treviño) on 2013-06-13

BamfFactory: register again a view if it is closed

562. By Marco Trevisan (Treviño) on 2013-06-13

BamfFactory: some code cleanup

561. By Marco Trevisan (Treviño) on 2013-06-13

BamfFactory: don't allow a view to be closed more than once, unreffing them

Also make sure that if we don't have a valid path, we try to remove the view by
iterating the hash-table.

560. By Marco Trevisan (Treviño) on 2013-06-13

BamfFactory: completely move the ownership of the registered views to the HashTable

The views are now ref'd when added to it and unreffed on removal.
Then it's up to the clients to handle their ownership in other cases.