Autopilot

Merge lp:~3v1n0/autopilot/bamf-gdk-dpy-1.3 into lp:autopilot/1.3

  1. bamf-gdk-dpy-1.3
  2. Merge into 1.3
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Thomi Richards
Approved revision: 343
Merged at revision: 346
Proposed branch: lp:~3v1n0/autopilot/bamf-gdk-dpy-1.3
Merge into: lp:autopilot/1.3
Diff against target: 12 lines (+1/-1)
1 file modified
autopilot/process/_bamf.py (+1/-1)
To merge this branch: bzr merge lp:~3v1n0/autopilot/bamf-gdk-dpy-1.3
Reviewer Review Type Date Requested Status
Thomi Richards (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+188972@code.launchpad.net

Commit message

Bamf: pass Gdk.Display to GdkX11.X11Window.foreign_new_for_display

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:343
http://jenkins.qa.ubuntu.com/job/autopilot-1.3-ci/28/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-1.3-saucy-amd64-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-1.3-saucy-armhf-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-1.3-saucy-i386-ci/12

Click here to trigger a rebuild:
http://s-jenkins:8080/job/autopilot-1.3-ci/28/rebuild

review: Approve (continuous-integration)
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

LGTM, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'autopilot/process/_bamf.py'
2--- autopilot/process/_bamf.py 2013-08-12 16:11:03 +0000
3+++ autopilot/process/_bamf.py 2013-10-03 02:02:26 +0000
4@@ -486,7 +486,7 @@
5 # FIXME: We need to use the gdk window here to get the real coordinates
6 geometry = self._x_win.get_geometry()
7 origin = GdkX11.X11Window.foreign_new_for_display(
8- get_display(), self._xid).get_origin()
9+ GdkX11.X11Display(), self._xid).get_origin()
10 return (origin[0], origin[1], geometry.width, geometry.height)
11
12 @property

Subscribers

People subscribed via source and target branches