Code review comment for lp:~28msec/zorba/get-descendant-node-by-ordpath

Revision history for this message
Markos Zaharioudakis (markos-za) wrote :

Within the for loop:

for (i = 0; i < numAttrs; i++)

in the case of (pos == OrdPath::DESCENDANT) the function should return false, no?

Also, please use csize (instead of ulong) for storing the size of vectors and for iterating over vectors.

Also, in for loops, do ++i instead of i++. It's a very tiny optimization, but it doesn't cost anything so why let it pass....

« Back to merge proposal