Merge lp:~1chb1n/ubuntu-openstack-ci/ubuntu-openstack-ci-mp-initial into lp:ubuntu-openstack-ci

Proposed by Ryan Beisner
Status: Merged
Merged at revision: 15
Proposed branch: lp:~1chb1n/ubuntu-openstack-ci/ubuntu-openstack-ci-mp-initial
Merge into: lp:ubuntu-openstack-ci
Diff against target: 78 lines (+19/-15)
4 files modified
README (+5/-0)
populate/amulet-properties.tmpl (+0/-1)
populate/deploy-properties.tmpl (+1/-1)
scan_merge_props.py (+13/-13)
To merge this branch: bzr merge lp:~1chb1n/ubuntu-openstack-ci/ubuntu-openstack-ci-mp-initial
Reviewer Review Type Date Requested Status
Ryan Beisner (community) Approve
Review via email: mp+237718@code.launchpad.net

Description of the change

adjust mp scanner logic, update readme

To post a comment you must log in.
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Go

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README'
2--- README 2014-10-03 14:43:06 +0000
3+++ README 2014-10-09 04:50:00 +0000
4@@ -42,6 +42,11 @@
5 and deploy from a local branch of the charm specified in the deployer
6 bundle yaml, as the jenkins repo seems to have some bad days.
7
8+ * For the launchpad librarian python routines to authenticate, you should
9+ manually create the OAUTH file and place it in
10+ /var/lib/jenkins/.config/tarmac/credentials on the jenkins master. The
11+ merge proposal scanner and tarmac require it.
12+
13 Jenkins Infrastructure Deployment:
14 ./deploy.py
15 cd deployment
16
17=== modified file 'populate/amulet-properties.tmpl'
18--- populate/amulet-properties.tmpl 2014-10-08 21:15:20 +0000
19+++ populate/amulet-properties.tmpl 2014-10-09 04:50:00 +0000
20@@ -4,4 +4,3 @@
21 MP_TRIGGER={{mp_web}}
22 MP_SRC_BR={{mp_src_br}}
23 MP_TGT_BR={{mp_tgt_br}}
24-
25
26=== modified file 'populate/deploy-properties.tmpl'
27--- populate/deploy-properties.tmpl 2014-10-08 21:15:20 +0000
28+++ populate/deploy-properties.tmpl 2014-10-09 04:50:00 +0000
29@@ -2,7 +2,7 @@
30 UBUNTU_RELEASE={{u_rls}}
31 OPENSTACK_RELEASE={{os_rls}}
32 INSTALLATION_SOURCE={{inst_src}}
33+DISPLAY_NAME={{display_name}}
34 MP_TRIGGER={{mp_web}}
35 MP_SRC_BR={{mp_src_br}}
36 MP_TGT_BR={{mp_tgt_br}}
37-
38
39=== modified file 'scan_merge_props.py'
40--- scan_merge_props.py 2014-10-08 21:15:20 +0000
41+++ scan_merge_props.py 2014-10-09 04:50:00 +0000
42@@ -95,23 +95,23 @@
43 conf_map['misc-conf']['state-dir'],
44 '{}.changed'.format(conf_map['misc-conf']['mp-state-file']))
45
46- if len(comps['added']) != 0:
47- logging.debug('added: \n{}'.format(yaml.dump(comps['added'],
48+ if len(comps['added']) > 0:
49+ logging.info('added: \n{}'.format(yaml.dump(comps['added'],
50 default_flow_style=False)))
51- if len(comps['rmvd']) != 0:
52- logging.debug('removed: \n{}'.format(yaml.dump(comps['rmvd'],
53- default_flow_style=False)))
54- if len(comps['diff']) != 0:
55- logging.debug('changed: \n{}'.format(yaml.dump(comps['diff'],
56- default_flow_style=False)))
57- if len(comps['same']) != 0:
58- logging.debug('same: \n{}'.format(yaml.dump(comps['same'],
59+ if len(comps['diff']) > 0:
60+ logging.info('changed: \n{}'.format(yaml.dump(comps['diff'],
61+ default_flow_style=False)))
62+ if len(comps['same']) > 0:
63+ logging.debug('unchanged: \n{}'.format(yaml.dump(comps['same'],
64 default_flow_style=False)))
65+ if len(comps['rmvd']) > 0:
66+ logging.info('removed: \n{}'.format(yaml.dump(comps['rmvd'],
67+ default_flow_style=False)))
68+ if len(changed) > 0:
69+ logging.debug('added or changed: \n{}'.format(
70+ yaml.dump(changed, default_flow_style=False)))
71
72 if len(changed) > 0 or len(comps['rmvd']) > 0:
73- # changes detected
74- logging.info('added or changed: \n{}'.format(
75- yaml.dump(changed, default_flow_style=False)))
76 # Write current branch state to file
77 osci_utils.write_yaml(state, mp_state_fn)
78 # Also write flat file containing new or changed branches

Subscribers

People subscribed via source and target branches