Merge lp:~1chb1n/mojo/py3-000 into lp:~ost-maintainers/mojo/py3

Proposed by Ryan Beisner
Status: Merged
Merged at revision: 463
Proposed branch: lp:~1chb1n/mojo/py3-000
Merge into: lp:~ost-maintainers/mojo/py3
Diff against target: 39 lines (+19/-1)
3 files modified
.bzrignore (+1/-0)
requirements.txt (+1/-1)
tox.ini (+17/-0)
To merge this branch: bzr merge lp:~1chb1n/mojo/py3-000
Reviewer Review Type Date Requested Status
Chris MacNaughton Approve
Review via email: mp+336287@code.launchpad.net

Commit message

Add tox for exercising in a pure python3 environment

Bump codetree to py3-compatible version.

With mojo having known py3-only issues, this commit adds some mechanics to be able to directly iterate on py3 via tox.

Reference: https://bugs.launchpad.net/charm-test-infra/+bug/1744007

To post a comment you must log in.
Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

This does, in fact, run mojo with py3

review: Approve
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Add tox for exercising in a pure python3 environment

With mojo having known py3-only issues, this commit adds some mechanics to be able to directly iterate on py3.

Reference: https://bugs.launchpad.net/charm-test-infra/+bug/1744007

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2017-03-10 04:34:26 +0000
3+++ .bzrignore 2018-01-18 10:08:55 +0000
4@@ -5,3 +5,4 @@
5 /.coverage
6 .idea
7 docs/www/*.html
8+.tox
9
10=== modified file 'requirements.txt'
11--- requirements.txt 2017-05-03 21:46:53 +0000
12+++ requirements.txt 2018-01-18 10:08:55 +0000
13@@ -1,3 +1,3 @@
14 # mojo requirements are listed both here and in setup.py, everything in
15 # setup.py must be installable by pip
16-codetree >= 0.1.1
17+bzr+lp:codetree#egg=codetree >= 0.1.6
18
19=== added file 'tox.ini'
20--- tox.ini 1970-01-01 00:00:00 +0000
21+++ tox.ini 2018-01-18 10:08:55 +0000
22@@ -0,0 +1,17 @@
23+# mojo_exec: build a py3 virtualenv and execute a basic mojo command to confirm py3-only functionality.
24+[tox]
25+envlist = mojo_exec
26+skipsdist = True
27+
28+[testenv]
29+setenv = VIRTUAL_ENV={envdir}
30+ PYTHONHASHSEED=0
31+passenv = HOME TERM
32+install_command =
33+ pip install --allow-unverified python-apt {opts} {packages}
34+
35+[testenv:mojo_exec]
36+basepython = python3
37+deps = -r{toxinidir}/requirements.txt
38+commands = pip install .
39+ mojo --version

Subscribers

People subscribed via source and target branches