Juju Charms Collection
ubuntu package

Merge lp:~1chb1n/charms/trusty/ubuntu/update-charm-proof into lp:charms/trusty/ubuntu

  1. Trusty Tahr (14.04)
  2. update-charm-proof
  3. Merge into trunk
Proposed by Ryan Beisner on 2016-03-28
Status: Merged
Merge reported by: Adam Israel
Merged at revision: not available
Proposed branch: lp:~1chb1n/charms/trusty/ubuntu/update-charm-proof
Merge into: lp:charms/trusty/ubuntu
Diff against target: 12 lines (+1/-1)
1 file modified
Makefile (+1/-1)
To merge this branch: bzr merge lp:~1chb1n/charms/trusty/ubuntu/update-charm-proof
Reviewer Review Type Date Requested Status
Review Queue (community) automated testing Needs Fixing on 2016-04-04
Adam Israel 2016-03-28 Approve on 2016-03-30
Review via email: mp+290196@code.launchpad.net

Commit Message

Update charm proof command re: new charm-tools.

Description of the Change

Update charm proof command re: new charm-tools

The refactored charm tools isn't backward-compatible with existing charm proof commands.

`charm proof` needs to be changed to `charm-proof`

https://bugs.launchpad.net/charms/+source/ubuntu/+bug/1562857

To post a comment you must log in.
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #2089 ubuntu for 1chb1n mp290196
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/2089/

uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #671 ubuntu for 1chb1n mp290196
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/671/

Adam Israel (aisrael) wrote :

Looks good to me! +1

review: Approve
Review Queue (review-queue) wrote :

The results (PASS) are in and available here: http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/3396/

review: Approve (automated testing)
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/3346/

review: Needs Fixing (automated testing)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2015-04-30 13:14:03 +0000
3+++ Makefile 2016-03-28 13:22:13 +0000
4@@ -9,7 +9,7 @@
5 lint: virtualenv
6 @echo Lint inspections and charm proof...
7 .venv/bin/flake8 --exclude hooks/charmhelpers tests
8- .venv/bin/charm proof
9+ .venv/bin/charm-proof
10
11 test: virtualenv
12 @echo No unit tests defined. This is an example placeholder.

Subscribers

People subscribed via source and target branches

to all changes: