Code review comment for lp:~1chb1n/charms/trusty/ubuntu/amulet-sentry-unit-array

Revision history for this message
Antonio Rosales (arosales) wrote :

In OSCI as well as in Charm CI the charm tests are passing.

The latest error I am seeing from OSCI above may be related to infrastructure as I see the following stack trace not around the charm but storage and bundle tester:

ERROR destroying storage: listing volumes: Get local error: record overflow
DEBUG:bundletester.utils:Updating JUJU_ENV: "osci-sv05" -> ""
Traceback (most recent call last):
  File ".venv/bin/bundletester", line 9, in <module>
    load_entry_point('bundletester==0.5.7', 'console_scripts', 'bundletester')()
  File "/var/lib/jenkins/checkout/ubuntu/.venv/local/lib/python2.7/site-packages/bundletester/", line 105, in main
    [report.emit(result) for result in run()]
  File "/var/lib/jenkins/checkout/ubuntu/.venv/local/lib/python2.7/site-packages/bundletester/", line 150, in __call__
  File "/var/lib/jenkins/checkout/ubuntu/.venv/local/lib/python2.7/site-packages/bundletester/", line 81, in destroy
    '-y', self.env_name, '--force'])
  File "/usr/lib/python2.7/", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['juju', 'destroy-environment', '-y', 'osci-sv05', '--force']' returned non-zero exit status 1
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Given the small change set, and the passing tests on LXC I am giving this a +1. An ~openStack charmer or ~charmer will still need to give their +1 and officially merge the request.


review: Approve (community)

« Back to merge proposal