Merge lp:~1chb1n/charms/trusty/rabbitmq-server/next.normalize-makefile-test-deps into lp:~openstack-charmers-archive/charms/trusty/rabbitmq-server/next

Proposed by Ryan Beisner
Status: Merged
Merged at revision: 118
Proposed branch: lp:~1chb1n/charms/trusty/rabbitmq-server/next.normalize-makefile-test-deps
Merge into: lp:~openstack-charmers-archive/charms/trusty/rabbitmq-server/next
Diff against target: 49 lines (+5/-4)
3 files modified
Makefile (+2/-2)
tests/00-setup (+2/-1)
tests/tests.yaml (+1/-1)
To merge this branch: bzr merge lp:~1chb1n/charms/trusty/rabbitmq-server/next.normalize-makefile-test-deps
Reviewer Review Type Date Requested Status
Corey Bryant (community) Approve
Review via email: mp+273590@code.launchpad.net

Description of the change

Update test dependencies and normalize Makefiles across *oscharms.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #11405 rabbitmq-server-next for 1chb1n mp273590
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/11405/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #10601 rabbitmq-server-next for 1chb1n mp273590
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/10601/

120. By Ryan Beisner

update sync target

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #11423 rabbitmq-server-next for 1chb1n mp273590
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/11423/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #10615 rabbitmq-server-next for 1chb1n mp273590
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/10615/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #7148 rabbitmq-server-next for 1chb1n mp273590
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
2015-10-06 18:52:22,208 _test_rmq_amqp_messages_all_units DEBUG: Get message from: 172.17.104.190 (rabbitmq-server/0 juju-osci-sv04-machine-2)
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12698773/
Build: http://10.245.162.77:8080/job/charm_amulet_test/7148/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

^ unrelated amulet rmq cluster failure. Re-running anyway.

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #7165 rabbitmq-server-next for 1chb1n mp273590
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12700386/
Build: http://10.245.162.77:8080/job/charm_amulet_test/7165/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Undercloud issue, pending resolution.

Since this MP doesn't touch tests or hooks, amulet failures are irrelevant.

Revision history for this message
Corey Bryant (corey.bryant) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2015-09-24 21:49:44 +0000
3+++ Makefile 2015-10-06 18:44:01 +0000
4@@ -26,7 +26,7 @@
5 > bin/charm_helpers_sync.py
6
7 sync: bin/charm_helpers_sync.py
8- @$(PYTHON) bin/charm_helpers_sync.py -c charm-helpers.yaml
9+ @$(PYTHON) bin/charm_helpers_sync.py -c charm-helpers-hooks.yaml
10 @$(PYTHON) bin/charm_helpers_sync.py -c charm-helpers-tests.yaml
11
12 publish: lint test
13@@ -36,7 +36,7 @@
14 test: .venv
15 @echo Starting tests...
16 env CHARM_DIR=$(CHARM_DIR) $(TEST_PREFIX) .venv/bin/nosetests \
17- --nologcapture --with-coverage unit_tests/
18+ -v --nologcapture --with-coverage unit_tests/
19
20 functional_test:
21 @echo Starting amulet tests...
22
23=== renamed file 'charm-helpers.yaml' => 'charm-helpers-hooks.yaml'
24=== modified file 'tests/00-setup'
25--- tests/00-setup 2015-09-03 18:58:14 +0000
26+++ tests/00-setup 2015-10-06 18:44:01 +0000
27@@ -4,7 +4,8 @@
28
29 sudo add-apt-repository --yes ppa:juju/stable
30 sudo apt-get update --yes
31-sudo apt-get install --yes python-amulet \
32+sudo apt-get install --yes amulet \
33+ distro-info-data \
34 python-cinderclient \
35 python-distro-info \
36 python-glanceclient \
37
38=== modified file 'tests/tests.yaml'
39--- tests/tests.yaml 2015-09-03 18:58:14 +0000
40+++ tests/tests.yaml 2015-10-06 18:44:01 +0000
41@@ -8,7 +8,7 @@
42 - ppa:juju/stable
43 packages:
44 - amulet
45- - python-amulet
46+ - distro-info-data
47 - python-cinderclient
48 - python-distro-info
49 - python-glanceclient

Subscribers

People subscribed via source and target branches