Merge lp:~1chb1n/charms/trusty/percona-cluster/vivid-fixup into lp:~openstack-charmers-archive/charms/trusty/percona-cluster/next

Proposed by Ryan Beisner
Status: Merged
Merged at revision: 67
Proposed branch: lp:~1chb1n/charms/trusty/percona-cluster/vivid-fixup
Merge into: lp:~openstack-charmers-archive/charms/trusty/percona-cluster/next
Diff against target: 26 lines (+12/-4)
1 file modified
hooks/percona_utils.py (+12/-4)
To merge this branch: bzr merge lp:~1chb1n/charms/trusty/percona-cluster/vivid-fixup
Reviewer Review Type Date Requested Status
Edward Hope-Morley Pending
OpenStack Charmers Pending
Review via email: mp+265555@code.launchpad.net

Description of the change

Fix for Vivid installation.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #6627 percona-cluster-next for 1chb1n mp265555
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/6627/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #6254 percona-cluster-next for 1chb1n mp265555
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/6254/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #6628 percona-cluster-next for 1chb1n mp265555
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/6628/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #6255 percona-cluster-next for 1chb1n mp265555
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/6255/

66. By Edward Hope-Morley

[hopem,r=thedac,james-page]

Add min-cluster-size config option. This allows the charm to wait
for a minimum number of peers to join before bootstrapping
percona and allowing relations to access the database.

Closes-Bug: 1475585

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #5257 percona-cluster-next for 1chb1n mp265555
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/5257/

67. By Ryan Beisner

fix up pxc56 server package selection on vivid, with mysql56 client

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #6260 percona-cluster-next for 1chb1n mp265555
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/6260/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #6633 percona-cluster-next for 1chb1n mp265555
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/6633/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #5263 percona-cluster-next for 1chb1n mp265555
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/5263/

68. By Ryan Beisner

update

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #6636 percona-cluster-next for 1chb1n mp265555
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/6636/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #6263 percona-cluster-next for 1chb1n mp265555
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/6263/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #5266 percona-cluster-next for 1chb1n mp265555
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/5266/

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Minor nit. See inline

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Yes that would work now, but there will be a point in time where > Utopic will fail, presuming we will eventually have an Ubuntu "Z" followed by an "A".

I've not raised that as a "future-bug" yet to raise awareness or propose a shift in logic, but in the uosci and amulet code, we already use different logic which should be future-proof, so long as python-distro-info is maintained.

Ubuntu release list: ['warty', 'hoary', 'breezy', 'dapper', 'edgy', 'feisty', 'gutsy', 'hardy', 'intrepid', 'jaunty', 'karmic', 'lucid', 'maverick', 'natty', 'oneiric', 'precise', 'quantal', 'raring', 'saucy', 'trusty', 'utopic', 'vivid']

Revision history for this message
Ryan Beisner (1chb1n) wrote :

^ The alternate method is to use distro-info's ordered list for comparison.

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Anyhoo, I'm happy to switch it to > Utopic to be consistent with the other os-charms. Just let me know.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/percona_utils.py'
2--- hooks/percona_utils.py 2015-07-22 11:17:09 +0000
3+++ hooks/percona_utils.py 2015-07-22 19:36:30 +0000
4@@ -48,10 +48,18 @@
5 OperationalError
6 )
7
8-PACKAGES = [
9- 'percona-xtradb-cluster-server-5.5',
10- 'percona-xtradb-cluster-client-5.5',
11-]
12+if lsb_release()['DISTRIB_CODENAME'] in ['vivid', 'wily']:
13+ # NOTE(beisner): pxc 5.6 client package is not available in Vivid, install
14+ # mysql 5.6 client instead per https://launchpad.net/bugs/1476845.
15+ PACKAGES = [
16+ 'percona-xtradb-cluster-server-5.6',
17+ 'mysql-client-5.6'
18+ ]
19+else:
20+ PACKAGES = [
21+ 'percona-xtradb-cluster-server-5.5',
22+ 'percona-xtradb-cluster-client-5.5',
23+ ]
24
25 KEY = "keys/repo.percona.com"
26 REPO = """deb http://repo.percona.com/apt {release} main

Subscribers

People subscribed via source and target branches