Merge lp:~1chb1n/charms/trusty/neutron-gateway/next1507-amulet-cleanup into lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next

Proposed by Ryan Beisner
Status: Merged
Merged at revision: 131
Proposed branch: lp:~1chb1n/charms/trusty/neutron-gateway/next1507-amulet-cleanup
Merge into: lp:~openstack-charmers-archive/charms/trusty/neutron-gateway/next
Diff against target: 26 lines (+1/-10)
2 files modified
tests/018-basic-utopic-juno (+0/-9)
tests/basic_deployment.py (+1/-1)
To merge this branch: bzr merge lp:~1chb1n/charms/trusty/neutron-gateway/next1507-amulet-cleanup
Reviewer Review Type Date Requested Status
Billy Olsen Approve
Review via email: mp+266289@code.launchpad.net

Description of the change

Oops, this syntax check pass caught that the neutron-gateway charm has been testing the next charm in deployments against stable charm counterparts.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #6647 neutron-gateway-next for 1chb1n mp266289
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/6647/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Oops, this syntax check pass caught that the neutron-gateway charm has been testing the next charm in deployments against stable charm counterparts.

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #7194 neutron-gateway-next for 1chb1n mp266289
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/7194/

Revision history for this message
Billy Olsen (billy-olsen) wrote :

LGTM, Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file 'tests/018-basic-utopic-juno'
2--- tests/018-basic-utopic-juno 2015-06-25 17:58:14 +0000
3+++ tests/018-basic-utopic-juno 1970-01-01 00:00:00 +0000
4@@ -1,9 +0,0 @@
5-#!/usr/bin/python
6-
7-"""Amulet tests on a basic quantum-gateway deployment on utopic-juno."""
8-
9-from basic_deployment import NeutronGatewayBasicDeployment
10-
11-if __name__ == '__main__':
12- deployment = NeutronGatewayBasicDeployment(series='utopic')
13- deployment.run_tests()
14
15=== modified file 'tests/basic_deployment.py'
16--- tests/basic_deployment.py 2015-07-15 17:22:52 +0000
17+++ tests/basic_deployment.py 2015-07-29 18:24:52 +0000
18@@ -25,7 +25,7 @@
19 """Amulet tests on a basic neutron-gateway deployment."""
20
21 def __init__(self, series, openstack=None, source=None, git=False,
22- stable=True):
23+ stable=False):
24 """Deploy the entire test environment."""
25 super(NeutronGatewayBasicDeployment, self).__init__(series, openstack,
26 source, stable)

Subscribers

People subscribed via source and target branches