Merge lp:~1chb1n/charms/trusty/neutron-api/next1507-amulet-cleanup into lp:~openstack-charmers-archive/charms/trusty/neutron-api/next

Proposed by Ryan Beisner on 2015-07-29
Status: Merged
Merged at revision: 129
Proposed branch: lp:~1chb1n/charms/trusty/neutron-api/next1507-amulet-cleanup
Merge into: lp:~openstack-charmers-archive/charms/trusty/neutron-api/next
Diff against target: 52 lines (+4/-13)
2 files modified
tests/018-basic-utopic-juno (+0/-9)
tests/basic_deployment.py (+4/-4)
To merge this branch: bzr merge lp:~1chb1n/charms/trusty/neutron-api/next1507-amulet-cleanup
Reviewer Review Type Date Requested Status
Billy Olsen 2015-07-29 Approve on 2015-07-29
Review via email: mp+266279@code.launchpad.net

Description of the Change

Consume the neutron-gateway/next charm instead of q-g/next in amulet tests; Remove unsupported releases from amulet tests.

To post a comment you must log in.

charm_lint_check #7182 neutron-api-next for 1chb1n mp266279
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/7182/

charm_unit_test #6646 neutron-api-next for 1chb1n mp266279
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/6646/

Billy Olsen (billy-olsen) wrote :

LGTM. Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file 'tests/018-basic-utopic-juno'
2--- tests/018-basic-utopic-juno 2015-04-16 21:36:14 +0000
3+++ tests/018-basic-utopic-juno 1970-01-01 00:00:00 +0000
4@@ -1,9 +0,0 @@
5-#!/usr/bin/python
6-
7-"""Amulet tests on a basic neutron-api deployment on utopic-juno."""
8-
9-from basic_deployment import NeutronAPIBasicDeployment
10-
11-if __name__ == '__main__':
12- deployment = NeutronAPIBasicDeployment(series='utopic')
13- deployment.run_tests()
14
15=== modified file 'tests/basic_deployment.py'
16--- tests/basic_deployment.py 2015-07-13 16:07:29 +0000
17+++ tests/basic_deployment.py 2015-07-29 17:35:12 +0000
18@@ -81,7 +81,7 @@
19 {'name': 'rabbitmq-server'}, {'name': 'keystone'},
20 {'name': 'neutron-openvswitch'},
21 {'name': 'nova-cloud-controller'},
22- {'name': 'quantum-gateway'},
23+ {'name': 'neutron-gateway'},
24 {'name': 'nova-compute'}]
25 super(NeutronAPIBasicDeployment, self)._add_services(this_service,
26 other_services)
27@@ -92,7 +92,7 @@
28 'neutron-api:shared-db': 'mysql:shared-db',
29 'neutron-api:amqp': 'rabbitmq-server:amqp',
30 'neutron-api:neutron-api': 'nova-cloud-controller:neutron-api',
31- 'neutron-api:neutron-plugin-api': 'quantum-gateway:'
32+ 'neutron-api:neutron-plugin-api': 'neutron-gateway:'
33 'neutron-plugin-api',
34 'neutron-api:neutron-plugin-api': 'neutron-openvswitch:'
35 'neutron-plugin-api',
36@@ -171,7 +171,7 @@
37 self.keystone_sentry = self.d.sentry.unit['keystone/0']
38 self.rabbitmq_sentry = self.d.sentry.unit['rabbitmq-server/0']
39 self.nova_cc_sentry = self.d.sentry.unit['nova-cloud-controller/0']
40- self.quantum_gateway_sentry = self.d.sentry.unit['quantum-gateway/0']
41+ self.neutron_gateway_sentry = self.d.sentry.unit['neutron-gateway/0']
42 self.neutron_api_sentry = self.d.sentry.unit['neutron-api/0']
43 self.nova_compute_sentry = self.d.sentry.unit['nova-compute/0']
44 u.log.debug('openstack release val: {}'.format(
45@@ -212,7 +212,7 @@
46 self.mysql_sentry: ['status mysql'],
47 self.keystone_sentry: ['status keystone'],
48 self.nova_cc_sentry: nova_cc_services,
49- self.quantum_gateway_sentry: neutron_services,
50+ self.neutron_gateway_sentry: neutron_services,
51 self.neutron_api_sentry: neutron_api_services,
52 }
53

Subscribers

People subscribed via source and target branches