Juju Charms Collection
mongodb package

Merge lp:~1chb1n/charms/trusty/mongodb/update-charm-proof into lp:charms/trusty/mongodb

  1. Trusty Tahr (14.04)
  2. update-charm-proof
  3. Merge into trunk
Proposed by Ryan Beisner on 2016-03-28
Status: Merged
Merge reported by: Adam Israel
Merged at revision: not available
Proposed branch: lp:~1chb1n/charms/trusty/mongodb/update-charm-proof
Merge into: lp:charms/trusty/mongodb
Diff against target: 32 lines (+2/-1)
3 files modified
Makefile (+1/-0)
metadata.yaml (+0/-1)
test_requirements.txt (+1/-0)
To merge this branch: bzr merge lp:~1chb1n/charms/trusty/mongodb/update-charm-proof
Reviewer Review Type Date Requested Status
Review Queue (community) automated testing Needs Fixing on 2016-04-04
Adam Israel 2016-03-28 Approve on 2016-03-30
Review via email: mp+290198@code.launchpad.net

Commit Message

Run charm-proof in lint make target; Update maintainers.

Description of the Change

Run charm-proof in lint make target; Update maintainers.

To post a comment you must log in.
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #2090 mongodb for 1chb1n mp290198
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/2090/

uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #1701 mongodb for 1chb1n mp290198
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/1701/

uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #672 mongodb for 1chb1n mp290198
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/672/

Adam Israel (aisrael) wrote :

Hey Ryan,

Thanks for updating this. You have my +1.

review: Approve
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/3395/

review: Needs Fixing (automated testing)
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/3345/

review: Needs Fixing (automated testing)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2015-10-07 14:16:56 +0000
3+++ Makefile 2016-03-28 13:31:15 +0000
4@@ -29,6 +29,7 @@
5
6 lint: .venv
7 .venv/bin/flake8 --exclude hooks/charmhelpers actions $(ACTIONS) hooks tests unit_tests
8+ .venv/bin/charm-proof
9
10 test: .venv
11 @echo Starting unit tests...
12
13=== modified file 'metadata.yaml'
14--- metadata.yaml 2015-11-13 16:33:49 +0000
15+++ metadata.yaml 2016-03-28 13:31:15 +0000
16@@ -1,7 +1,6 @@
17 name: mongodb
18 summary: An open-source document database, and the leading NoSQL database
19 maintainers:
20- - Juan Negron <juan.negron@canonical.com>
21 - Marco Ceppi <marco@ceppi.net>
22 - Charles Butler <chuck@dasroot.net>
23 description: |
24
25=== modified file 'test_requirements.txt'
26--- test_requirements.txt 2015-01-21 23:17:11 +0000
27+++ test_requirements.txt 2016-03-28 13:31:15 +0000
28@@ -3,3 +3,4 @@
29 nose>=1.3.1
30 flake8
31 filelock
32+charm-tools

Subscribers

People subscribed via source and target branches