Merge lp:~1chb1n/charms/trusty/keystone/kilo-support into lp:~openstack-charmers-archive/charms/trusty/keystone/next

Proposed by Ryan Beisner
Status: Merged
Merged at revision: 117
Proposed branch: lp:~1chb1n/charms/trusty/keystone/kilo-support
Merge into: lp:~openstack-charmers-archive/charms/trusty/keystone/next
Diff against target: 159 lines (+149/-0)
2 files modified
templates/kilo/keystone.conf (+105/-0)
templates/kilo/logging.conf (+44/-0)
To merge this branch: bzr merge lp:~1chb1n/charms/trusty/keystone/kilo-support
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Diogo Matsubara (community) Approve
Review via email: mp+248456@code.launchpad.net

Description of the change

Resolves Trusty-Kilo config-changed hook fail for https://bugs.launchpad.net/charms/+source/keystone/+bug/1417211.

Adds templates for kilo and fixes token section to point to the correct driver module: "driver = keystone.token.persistence.backends.sql.Token"

Pulled from matsubara's trunk MP, to test in OSCI overnight (thanks Diogo!).

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #1515 keystone-next for 1chb1n mp248456
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/1515/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #1470 keystone-next for 1chb1n mp248456
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/1470/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Manual deploy tests by Diogo on dellstack and by me on serverstack confirm general T:K happiness, though I want to wait for OSCI's full deployment tests to run to proceed on this.

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #1516 keystone-next for 1chb1n mp248456
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/1516/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #1471 keystone-next for 1chb1n mp248456
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/1471/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #1634 keystone-next for 1chb1n mp248456
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/1634/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #1635 keystone-next for 1chb1n mp248456
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
  ERROR subprocess encountered error code 124
  make: *** [test] Error 124

Full amulet test output: http://paste.ubuntu.com/10043093/
Build: http://10.245.162.77:8080/job/charm_amulet_test/1635/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Safe to disregard amulet test #1635, undercloud bootstrapping issue.

Revision history for this message
Diogo Matsubara (matsubara) wrote :

It looks all right to me.

review: Approve
Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'templates/kilo'
2=== added file 'templates/kilo/keystone.conf'
3--- templates/kilo/keystone.conf 1970-01-01 00:00:00 +0000
4+++ templates/kilo/keystone.conf 2015-02-03 22:16:27 +0000
5@@ -0,0 +1,105 @@
6+# kilo
7+###############################################################################
8+# [ WARNING ]
9+# Configuration file maintained by Juju. Local changes may be overwritten.
10+###############################################################################
11+[DEFAULT]
12+admin_token = {{ token }}
13+admin_port = {{ admin_port }}
14+public_port = {{ public_port }}
15+use_syslog = {{ use_syslog }}
16+log_config = /etc/keystone/logging.conf
17+debug = {{ debug }}
18+verbose = {{ verbose }}
19+public_endpoint = {{ public_endpoint }}
20+admin_endpoint = {{ admin_endpoint }}
21+bind_host = {{ bind_host }}
22+public_workers = {{ workers }}
23+admin_workers = {{ workers }}
24+
25+[database]
26+{% if database_host -%}
27+connection = {{ database_type }}://{{ database_user }}:{{ database_password }}@{{ database_host }}/{{ database }}{% if database_ssl_ca %}?ssl_ca={{ database_ssl_ca }}{% if database_ssl_cert %}&ssl_cert={{ database_ssl_cert }}&ssl_key={{ database_ssl_key }}{% endif %}{% endif %}
28+{% else -%}
29+connection = sqlite:////var/lib/keystone/keystone.db
30+{% endif -%}
31+idle_timeout = 200
32+
33+[identity]
34+driver = keystone.identity.backends.{{ identity_backend }}.Identity
35+
36+[credential]
37+driver = keystone.credential.backends.sql.Credential
38+
39+[trust]
40+driver = keystone.trust.backends.sql.Trust
41+
42+[os_inherit]
43+
44+[catalog]
45+driver = keystone.catalog.backends.sql.Catalog
46+
47+[endpoint_filter]
48+
49+[token]
50+driver = keystone.token.persistence.backends.sql.Token
51+provider = keystone.token.providers.uuid.Provider
52+
53+[cache]
54+
55+[policy]
56+driver = keystone.policy.backends.sql.Policy
57+
58+[ec2]
59+driver = keystone.contrib.ec2.backends.sql.Ec2
60+
61+[assignment]
62+driver = keystone.assignment.backends.{{ assignment_backend }}.Assignment
63+
64+[oauth1]
65+
66+[signing]
67+
68+[auth]
69+methods = external,password,token,oauth1
70+password = keystone.auth.plugins.password.Password
71+token = keystone.auth.plugins.token.Token
72+oauth1 = keystone.auth.plugins.oauth1.OAuth
73+
74+[paste_deploy]
75+config_file = keystone-paste.ini
76+
77+[extra_headers]
78+Distribution = Ubuntu
79+
80+[ldap]
81+{% if identity_backend == 'ldap' -%}
82+url = {{ ldap_server }}
83+user = {{ ldap_user }}
84+password = {{ ldap_password }}
85+suffix = {{ ldap_suffix }}
86+
87+{% if ldap_config_flags -%}
88+{% for key, value in ldap_config_flags.iteritems() -%}
89+{{ key }} = {{ value }}
90+{% endfor -%}
91+{% endif -%}
92+
93+{% if ldap_readonly -%}
94+user_allow_create = False
95+user_allow_update = False
96+user_allow_delete = False
97+
98+tenant_allow_create = False
99+tenant_allow_update = False
100+tenant_allow_delete = False
101+
102+role_allow_create = False
103+role_allow_update = False
104+role_allow_delete = False
105+
106+group_allow_create = False
107+group_allow_update = False
108+group_allow_delete = False
109+{% endif -%}
110+{% endif -%}
111
112=== added file 'templates/kilo/logging.conf'
113--- templates/kilo/logging.conf 1970-01-01 00:00:00 +0000
114+++ templates/kilo/logging.conf 2015-02-03 22:16:27 +0000
115@@ -0,0 +1,44 @@
116+# kilo
117+[loggers]
118+keys=root
119+
120+[formatters]
121+keys=normal,normal_with_name,debug
122+
123+[handlers]
124+keys=production,file,devel
125+
126+[logger_root]
127+{% if root_level -%}
128+level={{ root_level }}
129+{% else -%}
130+level=WARNING
131+{% endif -%}
132+handlers=file
133+
134+[handler_production]
135+class=handlers.SysLogHandler
136+level=ERROR
137+formatter=normal_with_name
138+args=(('localhost', handlers.SYSLOG_UDP_PORT), handlers.SysLogHandler.LOG_USER)
139+
140+[handler_file]
141+class=FileHandler
142+level=DEBUG
143+formatter=normal_with_name
144+args=('/var/log/keystone/keystone.log', 'a')
145+
146+[handler_devel]
147+class=StreamHandler
148+level=NOTSET
149+formatter=debug
150+args=(sys.stdout,)
151+
152+[formatter_normal]
153+format=%(asctime)s %(levelname)s %(message)s
154+
155+[formatter_normal_with_name]
156+format=(%(name)s): %(asctime)s %(levelname)s %(message)s
157+
158+[formatter_debug]
159+format=(%(name)s): %(asctime)s %(levelname)s %(module)s %(funcName)s %(message)s

Subscribers

People subscribed via source and target branches