Juju Charms Collection
cinder package

Merge lp:~1chb1n/charms/trusty/cinder/next1507-amulet-cleanup into lp:~openstack-charmers-archive/charms/trusty/cinder/next

  1. Trusty Tahr (14.04)
  2. next1507-amulet-cleanup
  3. Merge into next
Proposed by Ryan Beisner
Status: Merged
Merged at revision: 111
Proposed branch: lp:~1chb1n/charms/trusty/cinder/next1507-amulet-cleanup
Merge into: lp:~openstack-charmers-archive/charms/trusty/cinder/next
Diff against target: 13 lines (+0/-9)
1 file modified
tests/018-basic-utopic-juno (+0/-9)
To merge this branch: bzr merge lp:~1chb1n/charms/trusty/cinder/next1507-amulet-cleanup
Reviewer Review Type Date Requested Status
Billy Olsen Approve
Review via email: mp+266300@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #6654 cinder-next for 1chb1n mp266300
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
make: *** [test] Error 1
ERROR:root:Make target returned non-zero.

Full unit test output: http://paste.ubuntu.com/11961324/
Build: http://10.245.162.77:8080/job/charm_unit_test/6654/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #7193 cinder-next for 1chb1n mp266300
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/7193/

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Unit test failure is not due to this change, so LGTM. Approved.

Will look at providing an MP for the unit test failures.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file 'tests/018-basic-utopic-juno'
2--- tests/018-basic-utopic-juno 2015-04-16 21:36:11 +0000
3+++ tests/018-basic-utopic-juno 1970-01-01 00:00:00 +0000
4@@ -1,9 +0,0 @@
5-#!/usr/bin/python
6-
7-"""Amulet tests on a basic Cinder deployment on utopic-juno."""
8-
9-from basic_deployment import CinderBasicDeployment
10-
11-if __name__ == '__main__':
12- deployment = CinderBasicDeployment(series='utopic')
13- deployment.run_tests()

Subscribers

People subscribed via source and target branches