Merge ~0xnishit/ubuntu/+source/pppoeconf:merge-1.22-resolute into ubuntu/+source/pppoeconf:debian/sid

Proposed by Nishit Majithia
Status: Needs review
Proposed branch: ~0xnishit/ubuntu/+source/pppoeconf:merge-1.22-resolute
Merge into: ubuntu/+source/pppoeconf:debian/sid
Diff against target: 328 lines (+176/-2)
3 files modified
debian/changelog (+172/-0)
debian/control (+2/-1)
debian/install (+2/-1)
Reviewer Review Type Date Requested Status
Skia (community) Approve
git-ubuntu import Pending
Review via email: mp+496017@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Nishit Majithia (0xnishit) wrote :

More information mentioned in the bug: LP #2131902

Revision history for this message
Skia (skia) wrote :

LGTM, sponsored:
❯ dput ubuntu ../pppoeconf_1.22ubuntu1_source.changes
Uploading pppoeconf using ftp to ubuntu (host: upload.ubuntu.com; directory: /ubuntu)
running updatemaintainer: Stop if ubuntu changes are without ubuntu maintainer.
running checksum: verify checksums before uploading
running nobug: Stop if uploading without any bug reference.
running check-debs: makes sure the upload contains a binary package
running ppaforppaonly: Stop uploads to the archive with or to ppa without ~ppa suffix.
running badauthor: Stop if uploading with root@ or ubuntu@ email adresses.
running placeholderbug: Stop if using common placeholder numbers as bug reference.
running gitubuntu: Warn if uploading without git-ubuntu Vcs-* entries.
running required-fields: check whether a field is present and non-empty in the changes file
running releasemismatch: Warn about mismatching suffixesg e.g. focal with a XX.YY not being 20.04
running gpg: check GnuPG signatures before the upload
running supported-distribution: check whether the target distribution is currently supported (using distro-info)
{'allowed': ['release', 'proposed', 'backports', 'security'], 'known': ['release', 'proposed', 'updates', 'backports', 'security']}
running suite-mismatch: check the target distribution for common errors
Uploading pppoeconf_1.22ubuntu1.dsc
Uploading pppoeconf_1.22ubuntu1.tar.xz
Uploading pppoeconf_1.22ubuntu1_source.buildinfo
Uploading pppoeconf_1.22ubuntu1_source.changes

For next time, please also push the `git-ubuntu` tags (split/..., logical/..., reconstruct/..., and old/ubuntu, old/debian, new/debian). That helps a lot in the review.
Additionally, it's nice when people link the PPA they tested in directly from the MP (that's where we do the review), and also mention either the autopkgtest results, or in that case, that there is no autopkgtest available hence no results to show.

review: Approve

Unmerged commits

c1f8af7... by Nishit Majithia

reconstruct-changelog

7df2b85... by Nishit Majithia

update-maintainer

6599b56... by Nishit Majithia

merge-changelogs

64d0939... by Nishit Majithia

do not install the desktop file

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 16488eb..91dee02 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+pppoeconf (1.22ubuntu1) resolute; urgency=medium
7+
8+ * Merge with Debian unstable (LP: #2131902). Remaining changes:
9+ - do not install the desktop file
10+
11+ -- Nishit Majithia <nishit.majithia@canonical.com> Wed, 19 Nov 2025 15:24:14 +0530
12+
13 pppoeconf (1.22) unstable; urgency=medium
14
15 * Team upload of Debian team
16@@ -25,6 +32,13 @@ pppoeconf (1.22) unstable; urgency=medium
17
18 -- Andreas Tille <tille@debian.org> Sun, 01 Dec 2024 22:24:42 +0100
19
20+pppoeconf (1.21+nmu3ubuntu1) oracular; urgency=medium
21+
22+ * Merge with Debian unstable (LP: #2065201). Remaining changes:
23+ - do not install the desktop file
24+
25+ -- Zixing Liu <zixing.liu@canonical.com> Wed, 08 May 2024 12:16:22 -0600
26+
27 pppoeconf (1.21+nmu3) unstable; urgency=high
28
29 * Non-maintainer upload.
30@@ -32,6 +46,14 @@ pppoeconf (1.21+nmu3) unstable; urgency=high
31
32 -- Adrian Bunk <bunk@debian.org> Fri, 10 Feb 2023 01:46:49 +0200
33
34+pppoeconf (1.21+nmu2ubuntu1) jammy; urgency=medium
35+
36+ * Resynchronize with Debian, remaining changes
37+ debian/rules
38+ - do not install the desktop file
39+
40+ -- Sebastien Bacher <seb128@ubuntu.com> Fri, 12 Nov 2021 11:57:05 +0100
41+
42 pppoeconf (1.21+nmu2) unstable; urgency=medium
43
44 * Non-maintainer upload.
45@@ -50,6 +72,13 @@ pppoeconf (1.21+nmu1) unstable; urgency=medium
46
47 -- Holger Levsen <holger@debian.org> Fri, 01 Jan 2021 16:42:10 +0100
48
49+pppoeconf (1.21ubuntu1) utopic; urgency=medium
50+
51+ * Merge from debian unstable (LP: #1332926). Remaining changes:
52+ - do not install the desktop file
53+
54+ -- Angel Abad <angelabad@ubuntu.com> Sun, 22 Jun 2014 10:44:49 +0200
55+
56 pppoeconf (1.21) unstable; urgency=low
57
58 [ Stefan Lippers-Hollmann ]
59@@ -72,6 +101,15 @@ pppoeconf (1.21) unstable; urgency=low
60
61 -- Gregory Colpart <reg@debian.org> Fri, 27 Dec 2013 03:03:25 +0100
62
63+pppoeconf (1.20ubuntu1) oneiric; urgency=low
64+
65+ * Merge from debian unstable (LP: #799149). Remaining changes:
66+ - do not install the desktop file
67+ * Dropped change (Superceeded in debian)
68+ - do not depend on modconf
69+
70+ -- Bhavani Shankar <bhavi@ubuntu.com> Sun, 03 Jul 2011 13:15:14 +0200
71+
72 pppoeconf (1.20) unstable; urgency=low
73
74 * Fix pppoeconf.desktop (Closes: #590202)
75@@ -88,6 +126,14 @@ pppoeconf (1.20) unstable; urgency=low
76
77 -- Gregory Colpart <reg@debian.org> Sat, 23 Apr 2011 11:32:03 +0200
78
79+pppoeconf (1.19ubuntu1) lucid; urgency=low
80+
81+ * Merge from debian testing. Remaining changes: LP: #492141
82+ - do not install the desktop file
83+ - do not depend on modconf
84+
85+ -- Bhavani Shankar <right2bhavi@gmail.com> Thu, 03 Dec 2009 20:25:05 +0530
86+
87 pppoeconf (1.19) unstable; urgency=low
88
89 * Add support for gksu when X is enabled. (Closes: #548231)
90@@ -104,6 +150,14 @@ pppoeconf (1.19) unstable; urgency=low
91
92 -- Gregory Colpart <reg@debian.org> Sat, 07 Nov 2009 22:34:41 +0100
93
94+pppoeconf (1.18ubuntu1) intrepid; urgency=low
95+
96+ * Merge from debian unstable, remaining changes: (LP: #260870)
97+ - do not install the desktop file
98+ - do not depend on modconf
99+
100+ -- Bhavani Shankar <right2bhavi@gmail.com> Mon, 25 Aug 2008 19:06:29 +0530
101+
102 pppoeconf (1.18) unstable; urgency=low
103
104 * Fix two bashisms (read without variable).
105@@ -116,6 +170,16 @@ pppoeconf (1.18) unstable; urgency=low
106
107 -- Gregory Colpart (evolix) <reg@evolix.fr> Sun, 27 Jul 2008 03:06:31 +0200
108
109+pppoeconf (1.17ubuntu1) hardy; urgency=low
110+
111+ * Merge from debian unstable, remaining changes:
112+ - do not install the desktop file
113+ - do not depend on modconf
114+ - Modify Maintainer value to match the DebianMaintainerField
115+ specification.
116+
117+ -- Michael Vogt <michael.vogt@ubuntu.com> Mon, 03 Dec 2007 09:56:57 +0100
118+
119 pppoeconf (1.17) unstable; urgency=low
120
121 * Update menu file to new section Applications/System/Administration.
122@@ -126,6 +190,14 @@ pppoeconf (1.17) unstable; urgency=low
123
124 -- Gregory Colpart (evolix) <reg@evolix.fr> Sat, 11 Aug 2007 03:12:04 +0200
125
126+pppoeconf (1.16ubuntu1) gutsy; urgency=low
127+
128+ * Merge from debian unstable, remaining changes:
129+ - do not install the desktop file
130+ - do not depend on modconf
131+
132+ -- Michael Vogt <michael.vogt@ubuntu.com> Thu, 14 Jun 2007 10:20:11 +0200
133+
134 pppoeconf (1.16) unstable; urgency=low
135
136 * Fix changing usepeerdns enabled->disabled (Closes: #426392)
137@@ -145,6 +217,14 @@ pppoeconf (1.15) unstable; urgency=low
138
139 -- Gregory Colpart (evolix) <reg@evolix.fr> Sun, 27 May 2007 22:30:26 +0200
140
141+pppoeconf (1.14ubuntu1) gutsy; urgency=low
142+
143+ * Merge from debian unstable, remaining changes:
144+ - do not install the desktop file
145+ - do not depend on modconf
146+
147+ -- Michael Vogt <michael.vogt@ubuntu.com> Tue, 15 May 2007 11:20:05 +0200
148+
149 pppoeconf (1.14) unstable; urgency=low
150
151 * Add fallback when no pppoe support. (Closes: #404322)
152@@ -161,6 +241,12 @@ pppoeconf (1.13) unstable; urgency=low
153
154 -- Gregory Colpart (evolix) <reg@evolix.fr> Thu, 18 Jan 2007 09:24:22 +0100
155
156+pppoeconf (1.12ubuntu1) feisty; urgency=low
157+
158+ * Merge from debian unstable.
159+
160+ -- Michael Vogt <michael.vogt@ubuntu.com> Tue, 21 Nov 2006 19:39:46 +0100
161+
162 pppoeconf (1.12) unstable; urgency=low
163
164 * Correct missing backslash (Closes: #384777)
165@@ -189,6 +275,25 @@ pppoeconf (1.11) unstable; urgency=low
166
167 -- Gregory Colpart (evolix) <reg@evolix.fr> Mon, 24 Jul 2006 00:36:58 +0200
168
169+pppoeconf (1.10ubuntu3) edgy; urgency=low
170+
171+ * Remove broken zenity support, backport from Debian pppoeconf 1.12
172+ (Closes Malone: #54383)
173+
174+ -- Adrien Cunin <adri2000@gmail.com> Sat, 21 Oct 2006 18:52:23 +0200
175+
176+pppoeconf (1.10ubuntu2) edgy; urgency=low
177+
178+ * Remove dependency on modconf to get this installable again.
179+
180+ -- Tollef Fog Heen <tfheen@ubuntu.com> Wed, 12 Jul 2006 14:58:13 +0200
181+
182+pppoeconf (1.10ubuntu1) edgy; urgency=low
183+
184+ * Resynchronise with Debian.
185+
186+ -- Tollef Fog Heen <tfheen@ubuntu.com> Tue, 4 Jul 2006 14:56:04 +0200
187+
188 pppoeconf (1.10) unstable; urgency=low
189
190 * QA upload.
191@@ -214,6 +319,21 @@ pppoeconf (1.9) unstable; urgency=medium
192
193 -- Matej Vela <vela@debian.org> Sun, 22 Jan 2006 11:15:31 +0100
194
195+pppoeconf (1.8ubuntu2) breezy; urgency=low
196+
197+ * Apply patch from Daniel Haler to properly create pppoe stanzas in
198+ /etc/network/interfaces, which should really close #10080 this time.
199+
200+ -- Adam Conrad <adconrad@ubuntu.com> Tue, 11 Oct 2005 00:09:12 +1000
201+
202+pppoeconf (1.8ubuntu1) breezy; urgency=low
203+
204+ * Merge with Debian, bringing in a fix for Ubuntu bug #10080.
205+ * Drop all our changes (which have been committed upstream), except
206+ for the removal of the .desktop file that we don't want.
207+
208+ -- Adam Conrad <adconrad@ubuntu.com> Thu, 29 Sep 2005 13:32:03 +1000
209+
210 pppoeconf (1.8) unstable; urgency=low
211
212 * orphaning package, changed Maintainer
213@@ -233,6 +353,19 @@ pppoeconf (1.7) unstable; urgency=medium
214
215 -- Eduard Bloch <blade@debian.org> Sat, 30 Apr 2005 18:56:22 +0200
216
217+pppoeconf (1.6ubuntu2) breezy; urgency=low
218+
219+ * Handle non-eth*-named devices and include a nic-$iface line for those
220+ instead of the usual "plugin rp-pppoe.so $iface". Ubuntu #16127
221+
222+ -- Tollef Fog Heen <tfheen@ubuntu.com> Mon, 26 Sep 2005 12:06:01 +0200
223+
224+pppoeconf (1.6ubuntu1) breezy; urgency=low
225+
226+ * Resynchronise with Debian, resolving merge conflicts.
227+
228+ -- Adam Conrad <adconrad@0c3.net> Thu, 21 Apr 2005 09:23:41 +0000
229+
230 pppoeconf (1.6) unstable; urgency=high
231
232 * replaced -p with -o in the iptables call (stupid typo, closes: #304219)
233@@ -271,6 +404,12 @@ pppoeconf (1.2) unstable; urgency=medium
234
235 -- Eduard Bloch <blade@debian.org> Fri, 18 Feb 2005 01:12:39 +0100
236
237+pppoeconf (1.1ubuntu1) hoary; urgency=low
238+
239+ * Resynchronise with Debian.
240+
241+ -- Jeff Bailey <jbailey@ubuntu.com> Fri, 4 Mar 2005 07:41:17 -0500
242+
243 pppoeconf (1.1) unstable; urgency=high
244
245 * do not stumble over PPP usernames with slashes within (closes: #295315)
246@@ -278,6 +417,12 @@ pppoeconf (1.1) unstable; urgency=high
247
248 -- Eduard Bloch <blade@debian.org> Fri, 18 Feb 2005 01:07:21 +0100
249
250+pppoeconf (1.0.17ubuntu1) hoary; urgency=low
251+
252+ * Re-sync with debian
253+
254+ -- LaMont Jones <lamont@ubuntu.com> Tue, 11 Jan 2005 20:23:21 -0700
255+
256 pppoeconf (1.0.17) unstable; urgency=medium
257
258 * documented the potential need to fix the 0clampmss in README.Debian
259@@ -308,6 +453,13 @@ pppoeconf (1.0.14) unstable; urgency=low
260
261 -- Eduard Bloch <blade@debian.org> Sat, 11 Dec 2004 13:44:46 +0100
262
263+pppoeconf (1.0.13ubuntu1) hoary; urgency=low
264+
265+ * Resynchronise with Debian.
266+ * Take over debian/po/{pppoeconf.pot,templates.pot} from unstable.
267+
268+ -- Matthias Klose <m@klose.in-berlin.de> Mon, 15 Nov 2004 15:51:13 +0000
269+
270 pppoeconf (1.0.13) unstable; urgency=low
271
272 * inserting the MSS clamping rule as the first one
273@@ -325,6 +477,12 @@ pppoeconf (1.0.12) unstable; urgency=medium
274
275 -- Eduard Bloch <blade@debian.org> Thu, 04 Nov 2004 15:50:46 +0100
276
277+pppoeconf (1.0.11ubuntu1) hoary; urgency=low
278+
279+ * Sync back with Debian.
280+
281+ -- Daniel Stone <daniel.stone@canonical.com> Tue, 2 Nov 2004 16:28:59 +0100
282+
283 pppoeconf (1.0.11) unstable; urgency=low
284
285 * moved chmod +x to chmod 755 - which otherwise would break because of the
286@@ -353,6 +511,20 @@ pppoeconf (1.0.9) unstable; urgency=medium
287
288 -- Eduard Bloch <blade@debian.org> Sat, 18 Sep 2004 10:16:19 +0200
289
290+pppoeconf (1.0.8ubuntu2) warty; urgency=low
291+
292+ * Call pppoe_on_boot, instead of ppp_on_boot.dsl.
293+
294+ -- Daniel Stone <daniel.stone@canonical.com> Thu, 23 Sep 2004 13:49:39 +1000
295+
296+pppoeconf (1.0.8ubuntu1) warty; urgency=low
297+
298+ * New version which integrates with pppoe-enabled ppp, no longer requires
299+ the pppoe package
300+ * Don't install the .desktop file
301+
302+ -- Matt Zimmerman <mdz@canonical.com> Tue, 7 Sep 2004 08:23:40 -0700
303+
304 pppoeconf (1.0.8) unstable; urgency=low
305
306 * Setting group and permissions of self-created dsl-provider file according
307diff --git a/debian/control b/debian/control
308index 51519dd..e0ace9e 100644
309--- a/debian/control
310+++ b/debian/control
311@@ -1,5 +1,6 @@
312 Source: pppoeconf
313-Maintainer: Gregory Colpart <reg@debian.org>
314+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
315+XSBC-Original-Maintainer: Gregory Colpart <reg@debian.org>
316 Section: net
317 Priority: optional
318 Build-Depends: debhelper-compat (= 13)
319diff --git a/debian/install b/debian/install
320index 4a31581..58f7ca1 100644
321--- a/debian/install
322+++ b/debian/install
323@@ -1,3 +1,4 @@
324-pppoeconf.desktop usr/share/applications
325+# No .desktop file for Ubuntu, please...
326+#pppoeconf.desktop usr/share/applications
327 pppoeconf usr/sbin
328 pppoeconf.png usr/share/pixmaps

Subscribers

People subscribed via source and target branches