Comment 7 for bug 909708

you win

On Sun, Jan 1, 2012 at 12:44 PM, Siegfried Gevatter <email address hidden>wrote:

> 2012/1/1 Seif Lotfy <email address hidden>:
> > Instead of deleting what was inserted of that particular event why not
> > check the subjects of the event for validity then either start insertion
> > or throw out a warning. I fear deletion...
>
> Huh. Checking first is just slower, there's nothing bad with deleting
> the event (it's just like a rollback, only not a rollback because we
> don't commit until the end of everything). Throwing out a warning will
> stop ALL events from being inserted, so it's not a nice option.
>
> --
> You received this bug notification because you are subscribed to The
> Zeitgeist Project.
> https://bugs.launchpad.net/bugs/909708
>
> Title:
> Inserting event with two subjects with the same URI breaks the
> following event
>
> Status in Zeitgeist Framework:
> Confirmed
>
> Bug description:
> By the way our database is structured, all subjects of a same event
> must have different URIs.
>
> However, this isn't currently being checked, with the effect that the
> first subject is inserted correctly, while the second subject triggers
> the "existing event" exception and rolls back the event ID. This has
> the effect that the next event to be inserted will incorrectly have
> the same event ID (thus its subjects are mixed into whatever got saved
> of the first event and all sorts of weirdness :P).
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/zeitgeist/+bug/909708/+subscriptions
>