Comment 2 for bug 657285

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

I'm still able to reproduce this issue, even after the attached branch was merged in r6629. See the attached screenshot. Might be slightly trickier, but if you move the open window to overlap the building, you should be able to trigger it.

PS. The missing parts of the screenshot are reported as bug 1202146.

In general, you seem to have done a great job fixing bugs lately. That said, I think it would be better to submit separate branches/merge requests for each bug rather than gathering lots of fixes in one giant merge. First of all, it makes it easier to get an overview as all changes are related to a single issue. If there are any problems with the suggested patch, we can get those sorted out while merging the fixes for other bugs so that they don't get delayed in the mean time. It also makes it clearer to see what was fixed in a particular commit, for instance I don't know if all bugs linked to the branch recently merged can be set to Fix Committed or if only some of them can. If a bug is introduced by a particular commit, it is easy to look up what really changed in the future if the set of changes is smaller.

If bugs are closely related it would of course make sense to fix them at the same time, but if they are affecting unrelated parts of the code it is usually better to file separate merge requests (or alternatively wait until the first fix is in).

Keep up the good work. :)