(In reply to comment #54)
> However, I think this is "fixed" on 1.9.1 in the sense that I can start a 1.9.1
> build without immediately crashing. So perhaps the first patch is all that was
> needed there? (and all that would need backporting to 1.9.0.x)
Ah -- yes, the above is correct, based on Comment 52.
So, to sum up:
- The patch in attachment 335369 fixes this bug *in Firefox*
- That patch is already in both mozilla-central and 1.9.1.
- That patch needs approval1.9.0.x, to fix this bug in Firefox 3.0.x
- (The later patches are for correctness, to fix other places where this bug could hypothetically pop up in mozilla-based software. However, those later patches don't affect Firefox's behavior, and they aren't included in 1.9.1.)
Hence, I'm leaving the approval request open on attachment 335369.
(In reply to comment #54)
> However, I think this is "fixed" on 1.9.1 in the sense that I can start a 1.9.1
> build without immediately crashing. So perhaps the first patch is all that was
> needed there? (and all that would need backporting to 1.9.0.x)
Ah -- yes, the above is correct, based on Comment 52.
So, to sum up:
- The patch in attachment 335369 fixes this bug *in Firefox*
- That patch is already in both mozilla-central and 1.9.1.
- That patch needs approval1.9.0.x, to fix this bug in Firefox 3.0.x
- (The later patches are for correctness, to fix other places where this bug could hypothetically pop up in mozilla-based software. However, those later patches don't affect Firefox's behavior, and they aren't included in 1.9.1.)
Hence, I'm leaving the approval request open on attachment 335369.