Comment 9 for bug 405943

Revision history for this message
Max Bowsher (maxb) wrote :

Whilst running synaptics-report, there was a shell error message. The line:
        if [ $MAJOR -ge 1 ] && [ $MINOR -ge 4 ]; then
is inadequately quoted. As the line:
    # NOTE: this won't work outside of X
indicates, this part won't work outside of X, in which case $MAJOR and $MINOR will be empty strings. You should defensively quote them. ( [ "$MAJOR" -ge ......)

Also, the logic of the version test is wrong: Should be ( major > 1 || ( major == 1 && minor >= 4 ) ), not ( major >= 1 && minor >= 4 ).

Now, on to the actual attachment....