Comment 7 for bug 876649

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

debdiff applies cleanly and the package build fine in pbuilder.

I went ahead and uploaded it. I do I have one comment though. You should make sure to keep the origin of the items in debian/changelog clear. Usually that only contains changes to the packaging or patches that we carry against the upstream source. Sometimes we highlight upstream changes for new releases. That usually take the format of:

 * New upstream release.
  - First upstream change.
  - Second upstream change.
 * Some change to the packaging in the debian dir.
 * Some patch to the upstream sorce that we in Ubuntu added.

I changed the changelog entry to read:

  * New upstream release (LP: #876649).
   - Fixed lack of time zone in hebcalevents location auto-detect
   - Fixed schedule not outputting "Nothing listed" when no events
   - Fixed reading only first item on schedule.
   - Fixed mix-up of schedule and todo depending on which is called first.
   - Added reading of event location.
   - Removed hard-coding of New Jersey in determing metar ID by IP
   - Fixed inability to set volume when previously muted by user

This way the changes are clearly part of the new upstream release and not things that Ubuntu has added. Hope that makes sense.

Thanks for your work!