Comment 7 for bug 1796932

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

The returned values are clumped/sorted by urldistro:
https://github.com/virt-manager/virt-manager/blob/v1.5-maint/virtinst/osdict.py#L90
https://github.com/virt-manager/virt-manager/blob/v1.5-maint/virtinst/osdict.py#L382
https://github.com/virt-manager/virt-manager/blob/v1.5-maint/virtinst/osdict.py#L97
https://github.com/virt-manager/virt-manager/blob/v1.5-maint/virtinst/osdict.py#L105

Therefore the test should not use name but urldistro as well.

I haven't found an issue in the real code yet (it will order silverblue in the midst of fedora, but that is ok) due to that, so lets fix the tests. Upstream review might uncover if there is more to mind that I missed.

Needed for 1.5.x maintenance tree at https://github.com/virt-manager/virt-manager/tree/v1.5-maint

Submitted in https://github.com/virt-manager/virt-manager/pull/35

Built fine with the fix in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3461/+packages

I also extended the MP for the most current upload to include this
https://code.launchpad.net/~paelzer/ubuntu/+source/virt-manager/+git/virt-manager/+merge/356334