Ubuntu
usb-creator package

  1. Bug #582531
  2. Comment #3

Comment 3 for bug 582531

Revision history for this message
Roderick B. Greening (roderick-greening) wrote : Re: trunk: startup disk creation from .ISO files fails

Please show your test cases for demonstrating this patch works as desired. The logic may not cover all bases as you may think.

This commit was submitted to fix a specific issue, which altering the 'and' to 'or' may re-introduce. It needs to be tested with at least the following:

1) No usb/sd card inserted prior to startup and insertion of the usb/sd card both before and after selecting the ISO image.
2) Insert usb/sd card prior to startup and then selecting the ISO image.

Repeating the above two tests and performing a format on the usb/sd card should also be tested. In all cases, the startup button should be disabled if you do not have a valid target and source selected at the same time. The 'and' in the above commit says if I have a valid target (CAN_USE) AND it's a valid source. The 'or' used to break things differently.

I think the issue is bigger than what you see here.