Ubuntu
update-notifier package

  1. Bug #1640318
  2. Comment #4

Comment 4 for bug 1640318

Revision history for this message
Robie Basak (racb) wrote :

Looks good to accept into proposed, but:

<rbasak> bdmurray: for bug 1640318, why not use the errno module's symbolic constants rather than hardcoding a number everywhere? Also, that's a whole load of duplication - could that be in a "attempt_print" function or something?

14:26 <rbasak> bdmurray: That's more for the development release. I guess it probably doesn't matter too much for an SRU.

I'm still OK to accept this, but would you like the opportunity to change it first?