Comment 9 for bug 147294

Revision history for this message
Phil Bull (philbull) wrote :

Hi Michael,

Thanks for the extensive patch, it looks really good. I found a few reasonably minor issues which need to be addressed:

 * "cursor, use the Super+1" => "cursor, use Super+1"
 * For keycombos, use the <keycombo> and <keycap> tags rather "+", i.e. "Ctrl+Shift+Alt" => "<keycombo><keycap>Ctrl</keycap><keycap>Shift</keycap><keycap>Alt</keycap></keycombo>"
 * "It is used to change viewports" - as far as I can see, "workspace" should be used instead of "viewport". It might also be beneficial to create a link to the GNOME documentation which explains what a workspace is.
 * "By default there are, besides the core, the main plugins of Compiz as well as the main and extra plugins of Compiz Fusion installed" - the wording here seems a bit confusing.
 * The sect2 sections you've used should all have an id.
 * The note about the Super key is important enough to be a separate <note>, or at least its own paragraph.
 * "Default: Initiate cube free rotation" - this seems confusing, I'm not sure what is meant
 * Perhaps change the title from "Commands for default plugins" to "Keyboard shortcuts for the default visual effects"