Comment 2 for bug 338046

I'll package this later on today. Just a quick question about this bit of the patch though charles:

#ifdef HAVE_GIO
    str = NULL;
    if( !str ) str = g_get_user_special_dir( G_USER_DIRECTORY_DESKTOP );
    if( !str ) str = g_get_user_special_dir( G_USER_DIRECTORY_DOWNLOAD );
    if( !str ) str = tr_getDefaultDownloadDir( );
    pref_string_set_default ( PREF_KEY_DIR_WATCH, str );
    pref_flag_set_default ( PREF_KEY_DIR_WATCH_ENABLED, FALSE );
#endif

Shouldn't G_USER_DIRECTORY_DOWNLOAD take priority over G_USER_DIRECTORY_DESKTOP? It just so happens that both of these are set to ~/Desktop by default on Ubuntu, so will not matter to most people. However, I manually changed my XDG download directory to ~/Download, and would expect Transmission to choose this instead of my desktop when I first run it. The patch suggests that it will still choose my desktop as opposed to my download directory, unless I've misunderstood it.