This is a possible fix/workaround to the issue. The fundamental issue is that for IMAP folders we're sending round a deleted notification, when we're not really deleting the folder.
The patch avoids us closing the folder, which means we keep a valid URI for the folder, which means that the session store data gets correctly saved.
I think a mozmill tests isn't possible at the moment as we don't have IMAP fake server hooked up.
Also we should probably have a follow-up bug to change the folder deleted notification to take account of the empty trash situation. I suspect that change couldn't be applied to 3.0 or 3.1 hence the change I'm suggesting here.
Requesting two reviews as I want more eyes on it, especially with no tests.
Created an attachment (id=443009)
Possible fix
This is a possible fix/workaround to the issue. The fundamental issue is that for IMAP folders we're sending round a deleted notification, when we're not really deleting the folder.
The patch avoids us closing the folder, which means we keep a valid URI for the folder, which means that the session store data gets correctly saved.
I think a mozmill tests isn't possible at the moment as we don't have IMAP fake server hooked up.
Also we should probably have a follow-up bug to change the folder deleted notification to take account of the empty trash situation. I suspect that change couldn't be applied to 3.0 or 3.1 hence the change I'm suggesting here.
Requesting two reviews as I want more eyes on it, especially with no tests.