Comment 2 for bug 391969

Revision history for this message
Urs Fleisch (ufleisch) wrote :

There is a patch in the source packet, debian/patches/03_thunar-vfs-apply-umask-properly.patch, which changes

if (!_thunar_vfs_io_ops_mkdir (lp->data, 0755, THUNAR_VFS_IO_OPS_NONE, error))

to

if (!_thunar_vfs_io_ops_mkdir (lp->data, 0777 & ~umask(0), THUNAR_VFS_IO_OPS_NONE, error))

But this does not really apply umask properly, because the call to umask(0) will set the umask to 0 and return the old umask. mkdir() already respects the umask (see "man 2 umask" and "man 2 mkdir"). The correct line would probably be:

if (!_thunar_vfs_io_ops_mkdir (lp->data, 0777, THUNAR_VFS_IO_OPS_NONE, error))

This is also in the patch at http://bugs.gentoo.org/275516