Comment 10 for bug 1811730

Revision history for this message
Colin Ian King (colin-king) wrote :

Looks like the i386 build failed:

g++ -DHAVE_CONFIG_H -I. -I./src -DTDLOCALEDIR=\"/usr/share/locale\" -DGLIB_SUPPORT -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/dbus-1.0 -I/usr/lib/i386-linux-gnu/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -I/usr/include/libxml2 -DTDRUNDIR=\"/var/run/thermald\" -DTDCONFDIR=\"/etc/thermald\" -I src -Wreorder -Wsign-compare -Wreturn-type -Wunused-but-set-variable -Wformat -Wall -Wclobbered -Wempty-body -Wignored-qualifiers -Wmissing-field-initializers -Wtype-limits -Wuninitialized -Werror -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o src/thermald-thd_zone.o `test -f 'src/thd_zone.cpp' || echo './'`src/thd_zone.cpp
In file included from /usr/include/glib-2.0/glib.h:62:0,
                 from src/thermald.h:62,
                 from src/thd_common.h:27,
                 from src/thd_zone.h:30,
                 from src/thd_zone.cpp:34:
src/thd_zone.cpp: In member function ‘void cthd_zone::sort_and_update_poll_trip()’:
/usr/include/glib-2.0/glib/gmessages.h:345:43: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘std::vector<cthd_trip_point>::size_type {aka unsigned int}’ [-Werror=format=]
                                __VA_ARGS__)
                                           ^
src/thermald.h:73:24: note: in expansion of macro ‘g_debug’
 #define thd_log_debug g_debug
                        ^~~~~~~
src/thd_zone.cpp:131:2: note: in expansion of macro ‘thd_log_debug’
  thd_log_debug("sort_and_update_poll_trip: trip_points_size =%lu\n",
  ^~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
Makefile:839: recipe for target 'src/thermald-thd_zone.o' failed

@Anthony, I think you needed also to include:

commit bb7631163c8f3f44d0dc83690765cdb799664fd5
Author: Anuj Mittal <email address hidden>
Date: Wed Sep 26 10:34:15 2018 +0800

    Use correct format specifier for size_t

    %zu instead of %lu, otherwise on 32 bit:

    | ../git/src/thd_zone.cpp: In member function 'void cthd_zone::sort_and_update_poll_trip()':
    | ../git/src/thd_zone.cpp:106:16: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'std::vector<cthd_trip_point>::size_type' {aka 'unsigned int'} [-Werror=format=]
    | thd_log_debug("sort_and_update_poll_trip: trip_points_size =%lu\n",
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | trip_points.size());

    Signed-off-by: Anuj Mittal <email address hidden>

@Brain, can this be removed from -proposed and I'm hoping Antony can provide me a V2 that I can re-upload.