© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
f33e652
(Get the code!)
Thanks Ioanna for providing a patch and work with upstream maintainer.
I have some concern that I want to address before talking about sponsorship.
I haven't tested libguestfs, so my observation are only base on the patch you have provided upstream, and my concern inside Ubuntu.
I would have prefer to see upstream adopting an approach based on detecting if the host run 'Ubuntu' then apply the workaround, otherwise don't apply it. Instead of deploying the workaround everywhere regardless of the Linux distribution. IMHO, it would have look more cleaner and less risky since the ubuntu workaround involve a remove file operation. I would have prefer to isolate the 'rm' operation at the maximum and limit it only when really needed.
Talking about this 'rm' operation[0], it deletes a 'dpkg-managed' file part of systemd package[1]. It's a pretty critical package here, so you would understand I'm taking this seriously. I'm afraid this could impact user who benefit of this libguestfs workaround at next systemd package upgrade if the file is absent for instance, and possibly break the next pkg upgrade of systemd
Could you please verify that aspect ?
I'm also concern about what could be other potential impact in the absence of this file.
Ideally, I would definitely prefer not allowing libguestfs to do such operation.
Can you think of another way to fix this ?
Feel free to share your thoughts and correct me If I miss something I should know about this change, but so far this is some of my concern looking again looking the patch.
[0] - rm -f /etc/dhcp/
[1] - apt-file search /etc/dhcp/
systemd: /etc/dhcp/
Here's some changes to apply to the current debdiff
- The 'Eoan' version need to be changed from "1.40.2-2ubuntu1.1" to "1.40.2-2ubuntu2". Let's use "1.40.2-2ubuntu1.1" for Disco instead.
- Your quilt patch need to be rename from "appliance-
Regards,
Eric