Comment 2 for bug 2018707

Revision history for this message
Lukas Märdian (slyon) wrote :

I tried to confirm this fix, by running autopkgtests from ppa:xypron/merge-from-debian:

https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-xypron-merge-from-debian/mantic/amd64/s/securefs/20230508_083543_16f8d@/log.gz

https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-xypron-merge-from-debian/mantic/armhf/s/securefs/20230508_082923_10c29@/log.gz

There still seem to be some problems, please investigate the full logs above.
Especially, I think the SECUREFS_BINARY env variable needs to be applied to "command1".

Please make use of the `submittodebian` tool, to forward the patch to Debian once ready. Then cross-link the corresponding Debian bug report to this one, so we can drop the delta eventually.

Also, please consider providing a PPA test build and autopkgtest results next time, to make it easier for your sponsor to confirm the fix.

Finally, the test seems to be executed on amd64 only, is there a hard reason for it? If not we should consider adopting the test case accordingly (i.e. not hard-coding the "obj-x86_64-linux-gnu" directory):
```
autopkgtest [16:13:53]: test command2: cd obj-x86_64-linux-gnu && ./securefs_test
autopkgtest [16:13:53]: test command2: [-----------------------
bash: line 1: cd: obj-x86_64-linux-gnu: No such file or directory
autopkgtest [16:13:54]: test command2: -----------------------]
autopkgtest [16:13:54]: test command2: - - - - - - - - - - results - - - - - - - - - -
command2 FAIL non-zero exit status 1
```

Thanks!