Ubuntu
rhythmbox-plugin-alternative-toolbar package

  1. Bug #1703662
  2. Comment #2

Comment 2 for bug 1703662

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

I'm a bit concerned with the way this is packaged.

Why is it necessary to remove the LICENSE file, for instance? This is no the only source to ship one; it should probably remain and live with the rest of the documentation (such as with copyright). The right way to fix this would obviously be upstream, and since the upstream is also packaging for Debian and Ubuntu, this should be a simple fix.

There are also extra postinst, prerm files which I expect should not be needed. Again, this is not the first python package, isn't python3 already doing all that is necessary? Building the package should be done when the package is being built, not when it is installed or removed.

There is a relevant warning in the build logs:
E: dh_python3 dh_python3:173: no package to act on (python3-foo or one with ${python3:Depends} in Depends)

Finally, nothing currently Depends/Recommends rhythmbox-plugin-alternative-toolbar. This means it would not stay in main if promoted.

Please fix for the above. I see no other issues with this package.