Comment 92 for bug 805303

Revision history for this message
Aurélien Gâteau (agateau) wrote : Re: [Bug 805303] Re: Gtk-CRITICAL **: IA__gtk_widget_style_get: assertion `GTK_IS_WIDGET (widget)' failed with the default qt4 gui

Le 28/09/2011 22:49, Ken VanDine a écrit :
> The GTK patch makes these changes to the symbols, does anything we know
> of use them?
>
> @@ -4728,11 +4728,11 @@
> gtk_window_unstick@Base 2.8.0
> gtk_wrap_mode_get_type@Base 2.8.0
> hildon_gtk_file_chooser_install_properties@Base 2.10.0
> - ubuntu_gtk_hscrollbar_init@Base 2.24.5-0ubuntu2
> + ubuntu_gtk_get_use_overlay_scrollbar@Base 2.24.6-0ubuntu4
> ubuntu_gtk_menu_shell_activate_first@Base 2.23.90
> ubuntu_gtk_menu_shell_activate_mnemonic@Base 2.21.6-1ubuntu5.1
> - ubuntu_gtk_scrolled_window_init@Base 2.24.3-0ubuntu5
> - ubuntu_gtk_vscrollbar_init@Base 2.24.5-0ubuntu2
> + ubuntu_gtk_overlay_scrollbar_new@Base 2.24.6-0ubuntu4
> + ubuntu_gtk_set_use_overlay_scrollbar@Base 2.24.6-0ubuntu4
> ubuntu_gtk_widget_set_has_grab@Base 2.21.6-1ubuntu3
> ubuntu_menu_proxy_activate_menu@Base 2.21.6-1ubuntu5.1
> ubuntu_menu_proxy_get@Base 2.21.1-1ubuntu2

As far as I know, the old symbols were only used internally by our
overlay scrollbar GTK patch.

Regarding the new symbols, at least ubuntu_gtk_overlay_scrollbar_new()
could be marked hidden. The new overlay scrollbar patch uses this
function in 3 places within GTK so it can't be made static, but its
visibility could be changed so that it is not exposed to the outside
world. I am going to mark it as G_GNUC_INTERNAL.

ubuntu_gtk_set_use_overlay_scrollbar() must be kept visible, as it is
used by the Qt patch. For consistency I think
ubuntu_gtk_get_use_overlay_scrollbar() should be kept as well.

Aurélien