Comment 2 for bug 349623

Revision history for this message
Daniel Holbach (dholbach) wrote :

Do you think you can put up a debdiff for the next revision you work on? https://wiki.ubuntu.com/PackagingGuide/Recipes/Debdiff has more info about it

A few quick things I noticed in the review:
 - Standards-Version change and ${misc:Depends} addition not really necessary, or should be done in Debian.
 - desktop-file-utils shouldn't be needed as an explicit dependency (almost no other desktop package does this)
 - (LP: #349623) in debian/changelog will get this bug automatically closed on upload
 - the postinst/postrm is not necessary, calling dh_desktop in debian/rules will get them added automatically (your MimeType addition will help there.)