Comment 7 for bug 1973382

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks for the review, Steve!

> Why is --no-start there in the first place?

This was introduced in [1]. It is there because the versioned package handles restarting, as stated next in

> So perhaps the concerns about not restarting on upgrade of postgresql-common are moot, as long as the versioned package itself handles restarting?

With the current jammy delta in debhelper/debconf, the next build of postgresql-common will result in the following snippet being added in the postinst.

+if [ -z "${DPKG_ROOT:-}" ] && [ "$1" = upgrade ] && [ -d /run/systemd/system ] ; then
+ deb-systemd-invoke stop 'postgresql.service' >/dev/null || true
+fi

This will stop the service and not re-start it. The desired outcome of applying the proposed fix is to maintain the postinst script as it is now, for the next time the package is re-built (preventing a regression).

[1] https://salsa.debian.org/postgresql/postgresql-common/-/commit/36a608c4f69b47d546192a686b4ad7f8e86f9493