Comment 43 for bug 267141

On Wed, 2008-10-08 at 07:46 +0000, Steve Langasek wrote:
> I'm sorry to say that I don't think upgrading pm-utils to the new
> upstream version is a viable option for intrepid. Backporting a
> targeted fix may be, if someone wants to look into the code differences;
> but I think we should consider other fixes in the meantime, even if they
> end up being short-term.
>
> Of the two patches available, I'm afraid I'm not happy at all with
> hyperair's, which adds nearly 100% code duplication of the existing
> uswsusp method; that's not at all elegant or maintainable.
>
I agree that there is a lot of code duplication. I'll see if I can do
anything about this later today.
> James' patch, while making it more awkward to enable uswsusp, does
> address the core of this bug, which is that users should not lose the
> suspend method by having uswsusp installed. Being able to use uswsusp,
> which is a far-from-preferred method in Ubuntu, is very much secondary.
>
> So I think James' patch is the correct basis on which to move this bug
> forward. James, it's been mentioned that dropping a file in
> /etc/pm/config.d with the sleep method is enough to let users enable
> uswusp. Perhaps we should patch pm-utils to ship a file under
> /etc/pm/config.d by default, with commented examples of how to enable
> the alternate suspend methods? I don't believe that installation of the
> uswsusp package (or tuxonice support in the kernel) should cause these
> methods to be used automatically, given their non-preferred status
> within Ubuntu, so an example file seems best to me.
>
Actually, something I realized while I was making my patch is that
uswsusp is that dropping a file in /etc/pm/config.d, presumably
containing 'SLEEP_MODULE="uswsusp"' will make this bug resurface, since
this setting will cause uswsusp to be used for check_suspend and
do_suspend as well, unless of course, the build of s2ram is re-enabled
in uswsusp. Hence it's not just "more awkward" to enable uswsusp, it
involves a few setbacks that can only be fixed by making the same
invasive changes (unless there's a better approach) as the patch I've
made.
--
Chow Loong Jin