Comment 2 for bug 376766

Revision history for this message
Siegfried Gevatter (rainct) wrote :

Thank you for your patch. Here are some problems I see with it:

You mention "Removed the "-m 644" because files are already set to 644." in debian/changelog but this is already done in the latest Debian revision; you also fail to mention the "php_value memory_limit 32M" change. Additionally, bug 223842 and perhaps also bug 333620 will be fixed with this upload, so it wouldn't hurt to mention them in the changelog.

Further, are you sure you want all the changes in the locale/ directory?