Comment 8 for bug 2054621

Hi Brian,

Thank you for all the work you've been putting on this! The debdiff and the SRU paperwork (template) are looking great. I have a few comments below:

- The changelog entry looks good. Would you mind adding a reference to this bug there (check other changelog entries in the same file). It would be something like "d/p/fix-attribute-instantion-dangling-pointer.patch: [...]. (LP: #2054621)". This will instruct launchpad to close this bug when the package lands in the -updates pocket.

- Still in the changelog, you can target it to "jammy" instead of "UNRELEASED". The package will be uploaded as proposed here :)

- Now, regarding the patch file, since these are two different upstream commits, it would be better to have them each in a separate patch file, i.e., we want two new files under debian/patches (and two entries in debian/patches/series). The changelog would need to be adjusted accordingly.

- We only need one "Origin" entry in the DEP3 patch header. This will be solved once the point raised above is fixed.

- Finally, in the test plan, do you think we could just extract the code bits (enclosed in the php tags) from the test files, set the proper configuration in the php config files and check for expectations instead of running the test suite? This seems to be easier than running the test suite (that would require fetching the package sources, setting the user env, etc; instead of installing the package, changing config files and running the script).

Let me know if you need help with any of the above!