Comment 4 for bug 2054621

Thanks for the patch, Brian!

Since this is a potential fix for a stable Ubuntu release, we would need to follow our SRU process here.

Would you be willing to file the template in this bug for that?

All you need to do is to change this bug report original description to match the template at https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template.

Now, about the attached patch, it should be OK (and nice to include) the test related to this change available in the original upstream commit at https://github.com/php/php-src/commit/2f6a06ccb0ef78e6122bb9e67f9b8b1ad07776e1. The contents of those tests should be enough to serve as a reproducer and as input for an SRU test case.

In the link above for the upstream commit, I see a discussion regarding a test failure due to a memory overflow.

It seems that Dimitry Stogov fixed it in https://github.com/php/php-src/commit/f7c3f6e7e25471da9cfb2ba082a77cc3c85bc6ed. Do we also need that patch to be included here?

Finally, the DEP3 headers in the patch should not start with '## '. Please check the patches available in this package sources and use https://dep-team.pages.debian.net/deps/dep3/ as a reference. You could instead just download the patches directly from github (e.g., https://github.com/php/php-src/commit/2f6a06ccb0ef78e6122bb9e67f9b8b1ad07776e1.patch) and add the DEP3 headers in them.

Note that I can sponsor an upload for you in case you are willing to push this one forward. For this, you would need to also add a debian/changelog entry to your patch (you should provide an actual debdiff or a merge proposal in our git repository in launchpad - let me know if you need any help with that).