Comment 14 for bug 2054621

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote : Re: PHP crashes on Laravel 9+ with certain extensions

Hi Brian,

Sorry for the delay on reviewing your patch here. As you may know, we had the 24.04 freeze last week and there were other packages/transitions I needed to tend to.

Your patch LGTM. I made a couple minor adjustments in the changelog entry and replaced the patches for the ones ported to PHP 8.1 in the upstream project (the ones in the 8.1 branch) since the ones provided were not being cleanly applied in the package currently available in Jammy.

You can see all the changes here https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/php8.1/+git/php8.1/+merge/462003

Please review them to make sure you agree with them since I will be sponsoring this upload on your behalf.

I also updated the test plan to point to a modified version of the php8.1 sources which can generate the zend_test extension in a standalone package as we discussed before. I decided not to push them in to PPAs because we will need it in the exact same version as the php packages being tested and I cannot buld that in a ppa for the version currently available in jammy without major changes in the packaging sources. So whenever we are testing this, we will need to perform local builds of php8.1 to get those php8.1-zend-test packages.