Comment 6 for bug 1333462

Revision history for this message
Phillip Susi (psusi) wrote :

A few comments on your patch:

First, we prefer to work with bzr branches rather than diffs these days. You might want to see https://wiki.ubuntu.com/DistributedDevelopment.

Second, the changelog entry should mention the name of the patch, in addition to its description, and note that it is a cherry-pick from upstream, for example:

add-support-for-a-new-Linux-specific-GPT-partition-t.patch: Cherry pick upstream patch to add Linux own partition type code GUID for fs partitions on GPT disks (LP: #1333462)

Finally, it looks like you snuck in two other unrelated patches, which is a no-no.