Comment 3 for bug 1877270

Revision history for this message
Mohammad Heib (mohamadh) wrote :

Hi Jeff,
after testing the feature we see that some devlink functionality is missing in our driver and we must add them before adding the ROCE feature.

This missing functionality is the implementation of devlink reload and it was introduced upstream by the following two patches:

4383cfcc65e7 ("net/mlx5: Add devlink reload")
32680da71034 ("net/mlx5: Remove unneeded variable in mlx5_unload_one")

the above patches applied cleanly over your tree but we have some compiling issue since the following patch are missing:

 070c63f20f6c ("net: devlink: allow to change namespaces during reload")

these compiling issues can be resolved by aligned mlx5_devlink_reload_down to Focal devlink_ops->reload_down by removing the 'bool netns_change' parameter from mlx5_devlink_reload_down function.

Thanks,