Comment 8 for bug 1567064

Revision history for this message
Jon Maloy (maloy) wrote : RE: [Bug 1567064] Re: tipc: missing linearization of sk_buff

Hi,
I reported back to your colleague Joseph Salisbury on April 18th that the fix was tested and found ok. I have pasted in our conversation below. There must be a misunderstanding somewhere.

BR
///jon

>I just submitted an SRU request for inclusion in Xenial. The bug status
>will changed to "Fix Commited" when the fix lands in the -proposed
>repository. It will then changed to "Fix Released" when it is in the
>official kernel.

[...]

>>Hi,
>>I have installed and tested it as far as I could without being able to reproduce the problem.
>>You can go ahead.
>>
>>Thank you for your help.
>>///jon
>>
>> PS. I hope I will receive a hint when this is officially released, so I can alert the users who have seen the problem.

> -----Original Message-----
> From: <email address hidden> [mailto:<email address hidden>] On Behalf Of
> Kamal Mostafa
> Sent: Monday, 25 April, 2016 16:02
> To: Jon Maloy
> Subject: [Bug 1567064] Re: tipc: missing linearization of sk_buff
>
> This bug is awaiting verification that the kernel in -proposed solves
> the problem. Please test the kernel and update this bug with the
> results. If the problem is solved, change the tag 'verification-needed-
> xenial' to 'verification-done-xenial'.
>
> If verification is not done by 5 working days from today, this fix will
> be dropped from the source code, and this bug will be closed.
>
> See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
> to enable and use -proposed. Thank you!
>
>
> ** Tags added: verification-needed-xenial
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1567064
>
> Title:
> tipc: missing linearization of sk_buff
>
> Status in linux package in Ubuntu:
> In Progress
> Status in linux source package in Xenial:
> Fix Committed
>
> Bug description:
> The TIPC binding table sometimes fails to update correctly between
> nodes because we don't linearize nonlinear buffers at two places where
> it is needed in the code.
>
> In the upstream kernel at kernel.org, the following commit was applied
> on Nov 19th 2015:
>
> commit c7cad0d6f70cd4ce8644ffe528a4df1cdc2e77f5 ("tipc: move
> linearization of buffers to generic code") that fixes this issue.
>
> This crucial fix made it into kernel 4.5, but unfortunately not into
> 4.4 that is used in Xenial, and makes TIPC in Xenial almost unusable
> as it is now.
>
> Now I am uncertain about how to proceed with this, since I am new with dealing
> with the Ubuntu kernel.
> - Do you apply such fixes from kernel.org if I post a new one to
> kernel.org/stable? (The one referred to above won't apply cleanly to 4.4).
> - Or should I issue a new one directly to Ubuntu's kernel team ?
> - Or do you fix it yourself (it it pretty trivial and safe if you take a look at the
> original commit I refer to) ?
>
> BR
> Jon Maloy
> Ericsson Canada Inc
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1567064/+subscriptions