Is there a specific reason for depending on HID=POWER_SUPPLY?
I also noticed that the following upstream commit specifically notes issues with "recent userspace" which is why HID_BATTERY_STRENGTH has been defaulted to n because it's is causing problems on some systems. Have the userpace issues been resolved so we don't start breaking/regressing existing systems if we enable this?
Commit 4f5ca836b "HID: hid-input: add support for HID devices reporting
Battery Strength" added the CONFIG_HID_BATTERY_STRENGTH option to report
the battery strength of HID devices. The commit log explicitly mentions
it not working properly with recent userspace, but it is default y
anyway. This is rather odd, and actually causes problems on real
systems.
Hi Daniel,
I took a look at enabling this. Unfortunately I noticed the depends line in the Kconfig as follows:
config HID_BATTERY_ STRENGTH
bool "Battery level reporting for HID devices"
depends on HID && POWER_SUPPLY && HID = POWER_SUPPLY
In the Ubuntu configs for Quantal, the following is set which does not satisfy the depends policy for HID_BATTERY_ STRENGTH:
~/ubuntu- quantal/ debian. master/ config$ grep -rn "CONFIG_HID=" * common. ubuntu: 2088:CONFIG_ HID=m quantal/ debian. master/ config$ grep -rn "CONFIG_ POWER_SUPPLY= " * common. ubuntu: 4187:CONFIG_ POWER_SUPPLY= y
config.
~/ubuntu-
config.
Is there a specific reason for depending on HID=POWER_SUPPLY?
I also noticed that the following upstream commit specifically notes issues with "recent userspace" which is why HID_BATTERY_ STRENGTH has been defaulted to n because it's is causing problems on some systems. Have the userpace issues been resolved so we don't start breaking/regressing existing systems if we enable this?
commit 2198edddd8f0245 d4c47419310c6cf b0f4e1a197
Author: Josh Boyer <email address hidden>
Date: Wed Apr 18 10:05:17 2012 -0400
HID: default HID_BATTERY_ STRENGTH to no
Commit 4f5ca836b "HID: hid-input: add support for HID devices reporting HID_BATTERY_ STRENGTH option to report
Battery Strength" added the CONFIG_
the battery strength of HID devices. The commit log explicitly mentions
it not working properly with recent userspace, but it is default y
anyway. This is rather odd, and actually causes problems on real
systems.
This works around Fedora bug /bugzilla. redhat. com/show_ bug.cgi? id=806295
https:/