I just had a quick look at the patch:
1) why you moved the break from before case STATE_MENU_ICON to after that line? mistake?
2) while I agree we don't want to write g_assert for all shadow and padding lines, I don't like the fact we are skipping also other fallback options. I suggest to not use STATE_FALLBACK but a different (new) state like UBUNTU_STATE_FALLBACK, where we can skip the gasserts
I just had a quick look at the patch: STATE_FALLBACK, where we can skip the gasserts
1) why you moved the break from before case STATE_MENU_ICON to after that line? mistake?
2) while I agree we don't want to write g_assert for all shadow and padding lines, I don't like the fact we are skipping also other fallback options. I suggest to not use STATE_FALLBACK but a different (new) state like UBUNTU_