Comment 4 for bug 1801666

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

FYI:
Updated 2.6 https://launchpadlibrarian.net/393372504/buildlog_ubuntu-bionic-amd64.wireshark_2.6.3-1~ubuntu18.04.1_BUILDING.txt.gz
Release 2.4 https://launchpadlibrarian.net/358923533/buildlog_ubuntu-bionic-amd64.wireshark_2.4.5-1_BUILDING.txt.gz

Both carry wtap.h at the same place ./usr/include/wireshark/wiretap/wtap.h
So it did not move.

The inlcude is from File /usr/include/wireshark/epan/frame_data.h (same package) with the include line being
2.6: #include <wiretap/wtap.h>
2.4: didn't have that at all

So to include it at all is new, but as I said in cosmic it builds.
Now the call to build it in cosmic is the same as in bionic:

Config detection to build:
B: configure: wireshark_dissector: yes (CFLAGS='-pthread -I/usr/include/wireshark -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include' LIBS='-lwireshark -Wl,--export-dynamic -lgmodule-2.0 -pthread -lgthread-2.0 -pthread -lglib-2.0')
C: configure: wireshark_dissector: yes (CFLAGS='-pthread -I/usr/include/wireshark -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include' LIBS='-lwireshark -Wl,--export-dynamic -lgmodule-2.0 -pthread -lgthread-2.0 -pthread -lglib-2.0')

Call to build it:
B: libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../../tools -I.. -I../include -I../../../include -I../gnulib/lib -I../../../gnulib/lib -I../src -I../../../src -I../../../src/util -I../../.. -I wireshark/src -pthread -I/usr/include/wireshark -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 -c ../../../tools/wireshark/src/packet-libvirt.c -fPIC -DPIC -o wireshark/src/.libs/wireshark_src_libvirt_la-packet-libvirt.o
C: libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../../tools -I.. -I../include -I../../../include -I../gnulib/lib -I../../../gnulib/lib -I../src -I../../../src -I../../../src/util -I../../.. -I wireshark/src -pthread -I/usr/include/wireshark -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 -c ../../../tools/wireshark/src/packet-libvirt.c -fPIC -DPIC -o wireshark/src/.libs/libvirt_la-packet-libvirt.o

The target changed that is specified with -o due to libvirt changes, but nothing else.
I wonder if it might be something else that is needed to fix it, like a newer libtool or anything like that.