Comment 23 for bug 1714254

Revision history for this message
In , Michal (michal-redhat-bugs) wrote :

And I've pushed the patch:

commit 054c6d27214ef90feab3897b052f450492d5ef3f
Author: Michal Privoznik <email address hidden>
AuthorDate: Fri Sep 1 10:33:12 2017 +0200
Commit: Michal Privoznik <email address hidden>
CommitDate: Fri Sep 1 13:21:33 2017 +0200

    virnetdaemon: Don't deadlock when talking to D-Bus

    https://bugzilla.redhat.com/show_bug.cgi?id=1487322

    In ace45e67abbd I tried to fix a problem that we get the reply to
    a D-Bus call while we were sleeping. In that case the callback
    was never set. So I changed the code that the callback is called
    directly in this case. However, I hadn't realized that since the
    callback is called out of order it locks the virNetDaemon.
    Exactly the very same virNetDaemon object that we are dealing
    with right now and that we have locked already (in
    virNetDaemonAddShutdownInhibition())

    Signed-off-by: Michal Privoznik <email address hidden>

v3.7.0-rc2-5-g054c6d272