Comment 1 for bug 564070

Revision history for this message
Salvatore Bonaccorso (carnil) wrote : Re: Please sync libgtk2-perl from Debian (fixes FTBFS)

Hi Nathan

As discussed on IRC:

Here is the build-log for lucid/amd64 in my PPA http://launchpadlibrarian.net/44475213/buildlog_ubuntu-lucid-amd64.libgtk2-perl_1%3A1.221-6.lucid~ppa.1_FULLYBUILT.txt.gz

The issue is reproducible by building the -4ubuntu1 (or equivalently -5 in Debian) with new libgtk2.0-dev (>= 2.20).

The changes -4 to -4ubuntu1 in Ubuntu are:

libgtk2-perl (1:1.221-4ubuntu1) lucid; urgency=low

  * debian/patches/git-fix-gtkassistant.patch,
    debian/patches/git-fix-gtkbuildable.patch:
    - upstream git changes to fix build issues on gtk 2.19 (lp: #445621)

 -- Sebastien Bacher <email address hidden> Fri, 12 Mar 2010 13:28:39 +0100

libgtk2-perl (1:1.221-4build1) lucid; urgency=low

  * rebuild rest of main for armel armv7/thumb2 optimization;
    UbuntuSpec:mobile-lucid-arm-gcc-v7-thumb2

 -- Alexander Sack <email address hidden> Sat, 06 Mar 2010 13:34:18 +0100

The changes in Debian from -4 to -6 are:

libgtk2-perl (1:1.221-6) unstable; urgency=low

  * Add patch to fix test failures in GtkAction.t. Don't make assumptions
    about the number of proxies associated with the action. Thanks to Niko
    Tyni for reporting (Closes: #576493).
  * Refresh debian/copyright to revision 135 of Format-Specification for
    machine readable copyright file in DEP5 and update copyright for debian/*
    packaging.

 -- Salvatore Bonaccorso <email address hidden> Sun, 11 Apr 2010 19:07:52 +0200

libgtk2-perl (1:1.221-5) unstable; urgency=low

  [ gregor herrmann ]
  * New patches git-fix-gtkassistant.patch and git-fix-gtkbuildable.patch:
    upstream git changes to fix build issues on gtk 2.19; thanks to Sebastien
    Bacher for forwarding these patches from Ubuntu to us (closes: #573564).
  * Set Standards-Version to 3.8.4 (no changes).
  * Convert to source format 3.0 (quilt). Remove quilt framework.

  [ Damyan Ivanov ]
  * add -a option to xvfb-run invocation

 -- gregor herrmann <email address hidden> Sun, 04 Apr 2010 16:59:37 +0200

So the changes -4 -> -4ubuntu1 and -4 -> -5 in Debian are mostly the same, with addition of bumping Standards-Version, converting to source format 3.0 (quilt) and add -a option to xvb-run invocation. Therefore: if these changes are to mutch, for lucid to enter, please consider to apply the patch which was added in the -6 release in unstable:

---(patch)---
Description: Fix test failures in GtkAction.t. Don't make assumptions
 about the number of proxies associated with the action.
Origin: commit: 71800dd9dd835456fb07411b7b582fbad9dddfbe, http://git.gnome.org/browse/perl-Gtk2/commit/?id=71800dd9dd835456fb07411b7b582fbad9dddfbe
Bug: http://mail.gnome.org/archives/gtk-perl-list/2010-April/msg00026.html
Bug-Debian: http://bugs.debian.org/576493
Author: Torsten Schönfeld <email address hidden>
--- a/t/GtkAction.t
+++ b/t/GtkAction.t
@@ -5,7 +5,7 @@

 use Gtk2::TestHelper
  at_least_version => [2, 4, 0, "Action-based menus are new in 2.4"],
- tests => 19, noinit => 0;
+ tests => 17, noinit => 0;

 my $action = Gtk2::Action->new (name => 'Open',
                                 label => '_Open',
@@ -37,17 +37,11 @@
 $widget = $action->create_tool_item;
 isa_ok ($widget, 'Gtk2::ToolItem');

-my @proxies = $action->get_proxies;
-is (@proxies, 1);
-
 my $proxy = Gtk2::Button->new;
 $action->connect_proxy ($proxy);
-@proxies = $action->get_proxies;
-is (@proxies, 2);
-
+my @proxies = $action->get_proxies;
+ok (grep {$_ == $proxy} @proxies);
 $action->disconnect_proxy ($proxy);
-@proxies = $action->get_proxies;
-is (@proxies, 1);

 $action->connect_accelerator;
 $action->disconnect_accelerator;
---------------

Bests
Salvatore