© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> [Test plan]
Please could you add to the test plan testing to ensure that the new configurable timeout actually works? There's a lot of code being added just to make this configurable, including an entirely new configuration file and extensive by-hand C parsing code. I think we should ensure that this code actually works - otherwise I don't think including it all is justified.
> [Where problems could occur]
Am I right in thinking that it will no longer be possible to set an infinite lifetime, even by configuration? If we can't think of any case where a user would want this then I think it's fine to proceed as-is, but it's worth calling it out as a place where problems might occur.
--
One minor issue that's maybe worth fixing before landing this: the new manpage (including upstream) refers to a different configuration file path than where the code actually looks. Please could you patch to make them match - including in Jammy? Otherwise we rather defeat the point of including the new manpage in this SRU.