Comment 3 for bug 741867

Revision history for this message
Colin Watson (cjwatson) wrote :

This patch will break installing GRUB to a floppy disk, because the floppy_probe code in boot.S will be overwritten with whatever's currently in that location on the floppy. I think you probably need a condition a bit like this in there:

  if (allow_floppy && grub_util_biosdisk_is_floppy (dest_dev->disk))

After fixing this, would you mind sending the patch upstream (<email address hidden>) for review? It might be worth including a rationale rather like the inferred one I posted to the corresponding private bug, if you agree with it: i.e. that this seems to be because the BIOS is asserting that a partition boot record does not contain anything that looks a bit like a valid partition table.