Comment 5 for bug 242880

Revision history for this message
Sebastien Bacher (seb128) wrote :

thank you for your work on that, the changes seem to be mostly correct, some notes though:

changelog:
- some of the ubuntu changes are not listed in the summary, the samba and ntp installation patches and the network-admin apply button one, but that's a detail

control.in:
- the build-depends versionning changes are not required
- the standards-version downgrade is wrong
- the conflicts was a transitional things and not required now
- there is some description lines which have only spacing changes and are not required
- the gnome-network-admin replaces on gnome-system-tools version needs to be updated to the current version because the change is new in this ubuntu version

rules:
- the comments changes are not required

other good job, only the updated replaces version is required to not create conflicts errors on upgrade, other changes are cosmetic, could you do those changes and attach a new debdiff to the bug?